bugGNU patch - Bugs: bug #53353, intended @@ is making patch...


bug #53353: intended @@ is making patch sielntly (returning zero) crash

Submitter:  None
Submitted:  Thu 15 Mar 2018 04:51:55 PM UTC
Category:  Parser / Internal Representation Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup

Fri 16 Mar 2018 09:04:09 AM UTC, comment #2: 

Probably.. No one knows. Probably somebody was looking to at, and accidentally pressed space and saved.

jiri vanek <jvanek>
Thu 15 Mar 2018 06:21:09 PM UTC, comment #1: 

How did the patch get corrupted that way, by hand editing or fuzzing?

Andreas Gruenbacher <agruen>
Group administrator
Thu 15 Mar 2018 04:51:55 PM UTC, original submission:  

Attached is slightly corrupted patch - the @@ at line 21 have one leading space. When this patchis applied, it apply first hunk, and then exit with zero leaving file incompletly patched. The patch should die with non zero no later then during application of firs hunk

$ grep -nr -e @@
systemCryptoPolicyPR3183.patch:11:@@ -43,6 +43,9 @@
systemCryptoPolicyPR3183.patch:21: @@ -52,6 +55,10 @@
systemCryptoPolicyPR3183.patch:32:@@ -93,6 +100,7 @@
systemCryptoPolicyPR3183.patch:40:@@ -114,6 +122,31 @@
$ patch -p0 < systemCryptoPolicyPR3183.patch
patching file Security.java
Hunk #1 succeeded at 44 (offset 1 line).
$ echo $?
$ diff Security.java Security.java.comaprable
<  * <p>Additional default values of security properties are read from a
<  * system-specific location, if available.</p>
<  *

You can see the resulting file is very broken.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #43559:  Security.java added by None (42KiB - text/x-java)
file #43560:  Security.java.comaprable added by None (42KiB - application/octet-stream)
file #43561:  systemCryptoPolicyPR3183.patch added by None (3KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by jvanek (Posted a comment)
  • -email is unavailable- added by agruen (Posted a comment)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-07-28 agruen CategoryNone Parser / Internal Representation
    2018-03-15 None Attached File- Added Security.java, #43559
        Attached File- Added Security.java.comaprable, #43560
        Attached File- Added systemCryptoPolicyPR3183.patch, #43561

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code