GNU nano - Bugs: bug #52340, nano cannot build with -std=c89...
You are not allowed to post comments on this tracker with your current authentication level.
bug #52340: nano cannot build with -std=c89 due to mixed declarations and code
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Sun 05 Nov 2017 06:27:16 PM UTC | ||
Severity: | 2 - Minor | Status: | Wont Fix |
Assigned to: | None | Open/Closed: | Closed |
Jump to the original submission
Tue 07 Nov 2017 05:07:10 PM UTC, comment #6: |
Benno Schulenberg <bens> |
Mon 06 Nov 2017 09:06:32 PM UTC, comment #5: Well then, how about if I cut it down to the one known problem? The attached patch just displays numreplaced as signed, since it's ssize_t, and casts it to long instead of using the z modifier. That's only two fuzzed messages: "Replaced %ld occurrence"
|
David Lawrence Ramsey <dolorous> |
Mon 06 Nov 2017 08:24:18 PM UTC, comment #4: Hmm... That's a bit more than a handful. There are already six fuzzies and seven new strings. |
Benno Schulenberg <bens> |
Mon 06 Nov 2017 01:32:10 PM UTC, comment #3: The list of translated strings is relatively short: 16.
|
David Lawrence Ramsey <dolorous> |
Sun 05 Nov 2017 08:10:29 PM UTC, comment #2: Well, I've moved some declarations earlier because I wanted to be able to build nano on Haiku, which by default uses a pedantic gcc-2.95. I even submitted a patch for gnulib so Haiku could compile the glob module, but a few weeks later that change was undone, so it seems that the battle for C89 compatibility is lost.
|
Benno Schulenberg <bens> |
Sun 05 Nov 2017 06:30:08 PM UTC, comment #1: The attached patch against git c16e79b fixes the build errors (but not the warnings). |
David Lawrence Ramsey <dolorous> |
Sun 05 Nov 2017 06:27:16 PM UTC, original submission:
As of current git (c16e79b), nano cannot build with C89 compatibility, due to a few places that mix declarations and code; since mixed declarations and code have been fixed before, I'm assuming this is a problem.
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-13 | bens | Open/Closed | Open | Closed | |
2017-11-06 | dolorous | Attached File | - | Added 0001-replace-properly-display-numreplaced-as-signed-since.patch, #42338 | |
2017-11-06 | dolorous | Attached File | - | Added 0001-tweaks-use-printf-s-z-modifier-for-ssize_t-size_t.patch, #42334 | |
2017-11-05 | bens | Severity | 3 - Normal | 2 - Minor | |
Status | None | Wont Fix | |||
2017-11-05 | dolorous | Attached File | - | Added 0001-tweaks-fix-mixed-declarations-and-code.patch, #42332 |
Powered by Savane 3.13-02a9.
Corresponding source code
I have opted for fuzzying twelve messages, which are in fact six double messages that are all very similar, so it doesn't require much translator time. I've also included the things that don't affect translatable strings, but have left out the debug stuff, as I don't care about that.
The other translatable strings will be left for the overnext release.
Thanks for the patch.