GNU nano - Bugs: bug #52139, with softwrap, <Down> can...
You are not allowed to post comments on this tracker with your current authentication level.
bug #52139: with softwrap, <Down> can take too large a step on overwide tabs
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Thu 28 Sep 2017 07:49:28 PM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Thu 12 Oct 2017 07:19:10 PM UTC, comment #12: |
Benno Schulenberg <bens> |
Wed 11 Oct 2017 02:12:10 AM UTC, comment #11: I've put it through the same testing as before: in an 80x24 terminal, vertical upward movement (both <Up> and <PageUp>, with and without --smooth) works properly using tab sizes of 1, 2, 7, 9, 81, 132, 161, 219, 329, 2001, and 2397. |
David Lawrence Ramsey <dolorous> |
Sat 07 Oct 2017 12:28:59 AM UTC, comment #10: After some testing, it seems to work (aside from the issue you mentioned, which I can see in the 219-column tab case in my testing of the earlier version). Thanks. |
David Lawrence Ramsey <dolorous> |
Thu 05 Oct 2017 08:08:44 PM UTC, comment #9: The problem is that the start of a tab can be anywhere. The end of a tab can be computed with a simple formula, but a tab can start anywhere in maximum width that it occupies. So the actual column position of the tab needs to be computed in order to compare it to the left edge. See attached, improved patch.
|
Benno Schulenberg <bens> |
Sun 01 Oct 2017 10:11:00 PM UTC, comment #8: I've looked into it more, and proper_x() seems to be what's throwing off the leftedge and target into what you wouldn't expect (as far as I can tell; if you can give me a more specific example of what you don't expect, it would be more useful).
|
David Lawrence Ramsey <dolorous> |
Sun 01 Oct 2017 08:33:03 PM UTC, comment #7: Okay.
|
David Lawrence Ramsey <dolorous> |
Sun 01 Oct 2017 07:41:12 PM UTC, comment #6: Hm. I guess the forward part needs a second condition, just like the !forward part has two conditions. Will look into that later.
|
Benno Schulenberg <bens> |
Sun 01 Oct 2017 04:52:44 PM UTC, comment #5: More info regarding the report in comment #3:
|
David Lawrence Ramsey <dolorous> |
Sun 01 Oct 2017 04:35:00 PM UTC, comment #4: And with the attached file nanocrap2.txt, run:
|
David Lawrence Ramsey <dolorous> |
Sun 01 Oct 2017 04:28:55 PM UTC, comment #3: Running the same tests listed in bug #52125 with my nano binary, I've found one (admittedly obscure) case where this problem still happens, even with your last patch applied. With current git and your last patch applied, run:
|
David Lawrence Ramsey <dolorous> |
Sun 01 Oct 2017 03:00:29 AM UTC, comment #2: Okay, that makes sense; thanks for the explanation. And this patch does seem to work after some quick testing, although I still need to do the tests I did with the last patch to make sure.
|
David Lawrence Ramsey <dolorous> |
Sat 30 Sep 2017 07:40:25 PM UTC, comment #1: Okay, I think I've got it solved now. See attached patch.
|
Benno Schulenberg <bens> |
Thu 28 Sep 2017 07:49:28 PM UTC, original submission:
To reproduce, run on an 80-column terminal:
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-11-19 | bens | Open/Closed | Open | Closed | |
2017-10-12 | bens | Status | In Progress | Fixed | |
2017-10-05 | bens | Attached File | - | Added 0001-moving-prevent-the-cursor-sticking-on-or-skipping-ov.patch, #42071 | |
2017-10-01 | bens | Attached File | - | Added add-post-shift-indicator.patch, #42045 | |
2017-10-01 | dolorous | Attached File | - | Added nanocrap2.txt, #42042 | |
2017-10-01 | dolorous | Attached File | - | Added nanocrap.txt, #42039 | |
2017-09-30 | bens | Attached File | - | Added determine-when-to-nudge.patch, #42019 | |
Status | None | In Progress | |||
Assigned to | None | bens | |||
Carbon-Copy | - | Added dolorous |
Powered by Savane 3.13-f8d8.
Corresponding source code
Fixed in git, 7a3a45e6. Thanks for the extensive testing.