bugGNU nano - Bugs: bug #51821, selecting text no longer...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51821: selecting text no longer highlights it

Submitter:  Benno Schulenberg <bens>
Submitted:  Tue 22 Aug 2017 04:05:38 PM UTC
   
 
Severity:  5 - Blocker Status:  Fixed
Assigned to:  dolorous Open/Closed:  Closed

Tue 22 Aug 2017 05:30:16 PM UTC, comment #2: 

Thanks for the quick fix!  Pushed to master, a850bb25.

And closing, because unreleased.

Benno Schulenberg <bens>
Group administrator
Tue 22 Aug 2017 04:56:12 PM UTC, comment #1: 

The attached patch should fix it.  edit_redraw() should always be called on the line we moved from, not the line we're on, so was_current was actually needed.  (The patch also adds it back to do_left() and do_right(), so that only one edit_redraw() call is needed for those.)

(file #41617)

David Lawrence Ramsey <dolorous>
Group Member
Tue 22 Aug 2017 04:05:38 PM UTC, original submission:  

To reproduce, run src/nano +1 NEWS, then type M-A and press <Down> several times.  Nothing is highlighted.  Now press ^L.  The highlight appears.

In the revamping of the scrolling in commit 5e105287 we have trimmed away too many lines of code.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dolorous (Updated the item)
  • -email is unavailable- added by bens (Submitted the item)
  • -email is unavailable- added by bens
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-22 bens StatusNone Fixed
        Assigned toNone dolorous
        Open/ClosedOpen Closed
    2017-08-22 dolorous Attached File- Added 0001-moving-call-edit_redraw-on-the-proper-line-when-movi.patch, #41617
    2017-08-22 bens Carbon-Copy- Added dolorous

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code