GNU nano - Bugs: bug #51669, whitespace display mode shows two...
You are not allowed to post comments on this tracker with your current authentication level.
bug #51669: whitespace display mode shows two tab characters for tabs split across rows
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Sat 05 Aug 2017 09:02:22 PM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Tue 22 Aug 2017 02:52:58 PM UTC, comment #10: |
Benno Schulenberg <bens> |
Thu 17 Aug 2017 07:07:56 PM UTC, comment #9: Thanks for the patch. Pushed as e09dbf18. |
Benno Schulenberg <bens> |
Thu 17 Aug 2017 07:04:58 AM UTC, comment #8: Thank you. However, there's one case I just found that your fix doesn't cover. I originally found it while adding tabs to the nano binary, but I've come up with a simpler case.
|
David Lawrence Ramsey <dolorous> |
Mon 14 Aug 2017 07:36:10 PM UTC, comment #7: Wow... extensive testing. I just fiddled a bit with the terminal width and thought it looked okay. :) And did this quick test both with and without --atblanks.
|
Benno Schulenberg <bens> |
Mon 14 Aug 2017 06:03:39 PM UTC, comment #6: After some testing, your patch does seem to cover all the cases I've tried, and it doesn't seem to be overlooking anything so far. Thanks.
|
David Lawrence Ramsey <dolorous> |
Mon 14 Aug 2017 09:37:43 AM UTC, comment #5: Attached is a simplified patch that also handles the case from comment #4. Is there anything I'm overlooking? |
Benno Schulenberg <bens> |
Sun 13 Aug 2017 04:28:55 AM UTC, comment #4: Specifically, the problem the patch doesn't fix is reproduced as follows (from Benno Schulenberg, bug #51621):
|
David Lawrence Ramsey <dolorous> |
Sun 13 Aug 2017 03:44:47 AM UTC, comment #3: Thinking about it more, maybe the entire approach is wrong, and the changes to fix this need to be made in edit_draw() or something along those lines? |
David Lawrence Ramsey <dolorous> |
Sun 13 Aug 2017 03:27:28 AM UTC, comment #2: Actually, after more testing, it improperly blocks whitespace display of some tabs that start at the middle of a chunk, if the chunk is broken early due to atblanks softwrapping. No fix for this yet. |
David Lawrence Ramsey <dolorous> |
Sat 05 Aug 2017 09:06:20 PM UTC, comment #1: The attached patch fixes this. |
David Lawrence Ramsey <dolorous> |
Sat 05 Aug 2017 09:02:22 PM UTC, original submission:
Currently, in git 94b484e, if softwrap mode and whitespace display mode are both on, and a file contains enough tabs to wrap from one row onto the next, whitespace display mode will display a tab character both at the beginning of the tab, and at where the tab begins on the next row.
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-08-22 | bens | Open/Closed | Open | Closed | |
2017-08-17 | dolorous | Attached File | - | Added 0001-display-always-display-whitespace-characters-for-tab.patch, #41552 | |
Attached File | - | Added nulltest.txt, #41553 | |||
2017-08-14 | bens | Status | In Progress | Fixed | |
2017-08-14 | dolorous | Attached File | - | Added tabtests.zip, #41520 | |
2017-08-14 | bens | Attached File | - | Added suppress-showing-partial-tabs-at-leftedge.patch, #41512 | |
Status | None | In Progress | |||
Assigned to | None | bens | |||
2017-08-05 | dolorous | Attached File | - | Added 0001-display-don-t-show-visible-characters-for-softwrappe.patch, #41428 |
Powered by Savane 3.13-758e.
Corresponding source code
The problem was unreleased, thus closing this.