bugGNU FreeIPMI - Bugs: bug #51105, The script ganglia_ipmi_sensors.pl...

 
 

bug #51105: The script ganglia_ipmi_sensors.pl can break your entire Ganglia with buggy IPMI servers

Submitted by:  Josef Ridky <jridky>
Submitted on:  Wed 24 May 2017 09:55:58 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Improper Behaviour
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 24 May 2017 06:40:41 PM UTC, comment #1:

In principle a good idea. Although I think it should output something to warn the user.

if ($id_string =~ /[\x00-\x1F]/) {
print "something error message"
next;
}

Another alternate idea. Perhaps the junk characters could be converted into something readable? Just spaces? This would be great if the junk characters are at the end of the string (i.e. vendor didn't NUL terminate whatever they stuck in the firmware).

Albert Chu <chu11>
Project Administrator
Wed 24 May 2017 09:55:58 AM UTC, original submission:

Description of problem:

On some buggy servers is possible to get IPMI sensors with non-printable characters in the name. If you use the script ganglia_ipmi_sensors.pl to send the sensor data to Ganglia, the script sends these sensors breaking the whole Ganglia installation, because gmetad can not parse the output from gmond, due to these invalid characters

How reproducible:

Always

Steps to Reproduce:
1. You need a server that reports invalid characters in sensor names
2. Send the data to Ganglia with ganglia_ipmi_sensors.pl
3. Ganglia will stop reporting data.

For more info, visit https://bugzilla.redhat.com/show_bug.cgi?id=1049630

Josef Ridky <jridky>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40777:  ganglia_ipmi_sensors.patch added by jridky (496B - text/x-patch - proposed patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chu11 (Posted a comment)
  • -unavailable- added by jridky (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 24 May 2017 09:55:58 AM UTCjridkyAttached File-=>Added ganglia_ipmi_sensors.patch, #40777

    Back to the top


    Powered by Savane 3.1-cleanup1