bugGNU Wget - Bugs: bug #50528, make check (iri-disabled) fails on...

 
 

bug #50528: make check (iri-disabled) fails on mac os x

Submitted by:  Stephen G <stepheng>
Submitted on:  Mon 13 Mar 2017 12:19:10 AM UTC  
 
Category: TestingSeverity: 3 - Normal
Priority: 5 - NormalStatus: Inspected
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Open
Release: 1.19.1Operating System: Mac OS
Reproducibility: Every TimeFixed Release: None
Planned Release: NoneRegression: None
Work Required: NonePatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 07 Apr 2017 09:14:26 AM UTC, comment #8:

Your seem to be able to test on OSX. Maybe you could add some lines of Perl opening a composed filename and then check with diropen/readdir if that file exists. If not, the filesystem works with a 'translation layer'. In this case, skip the test by returning 77.

Tim Ruehsen <rockdaboot>
Project Administrator
Wed 05 Apr 2017 08:17:44 PM UTC, comment #7:

Please disregard my previous comment. This tests tries to write files with names encoded in iso-8859-1. Not sure if it possible with Mac OS X, because on HFS+ file names are stored as NFD Unicode:
https://developer.apple.com/library/content/qa/qa1173/_index.html

Probably this test can be skipped on Mac OS X.

Anton Yuzhaninov <citrin>
Wed 05 Apr 2017 04:23:20 PM UTC, comment #6:

FYI: Mac OS uses NFD in file names. Probably test can convert name to NFC using Unicode::Normalize.

Anton Yuzhaninov <citrin>
Wed 15 Mar 2017 12:51:55 PM UTC, comment #5:

Thanks, your output looks like mine here on Linux (ignoring dates and '`). Except the result... that means, your filesystem changes the bytes in the filenames. A later check byte-by-byte, using diropen/readdir, fails.

We addressed a similar issue in the Wget2 test suite (e.g. HFS+ is case insensitive) where I check for case sensitivity of the filesystem and amend the checks regarding of the result.

I am not going to backport that (C code) to wget 1.x (Perl or Python). But if anyone makes up a patch, it'll be welcome.
The code is in (wget2) tests/libtest.c, wget_test_check_filesystem().

Tim Ruehsen <rockdaboot>
Project Administrator
Mon 13 Mar 2017 08:54:16 PM UTC, comment #4:

I'm currently on journaled HFS

Content (IOContent): Apple_HFS
File System Personality: Journaled HFS+
Type (Bundle): hfs
Name (User Visible): Mac OS Extended (Journaled)
Journal: Journal size 40960 KB at offset 0xe8a000
Owners: Enabled

Stephen G <stepheng>
Mon 13 Mar 2017 08:36:40 PM UTC, comment #3:

I just pushed a commit to run Perl tests with -d (debug output).
Please git pull and 'make check' again. Than upload test-suite.log again.
What fileystem are you using ?
Maybe there is another layer that changes file names...

Tim Ruehsen <rockdaboot>
Project Administrator
Mon 13 Mar 2017 04:36:41 PM UTC, comment #2:

attached logs and test-suite.log.

i was able to reproduce on git master (those are the bootstrapconfigmakecheck.txt and the test-suite.log from git master entries)

Stephen G <stepheng>
Mon 13 Mar 2017 09:41:52 AM UTC, comment #1:

The link doesn't exist any more. Maybe you can upload the log here ?

Please also check #50233

Tim Ruehsen <rockdaboot>
Project Administrator
Mon 13 Mar 2017 12:19:10 AM UTC, original submission:

on a homebrew build (https://bot.brew.sh/job/Homebrew%20Core/18182/), make check fails for the iri-disabled test.

I tried to google what the issue was, but quickly got confused on the status (if it's not supposed to be addressed because of the upcoming python test suite, etc).

reproduced in non-ruby forked shell as well

Stephen G <stepheng>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40001:  test-suite.log added by stepheng (11KiB - application/octet-stream - from git master with debug)
file #39993:  test-suite.log added by stepheng (6KiB - application/octet-stream - from git master)
file #39990:  test-suite.log added by stepheng (6KiB - application/octet-stream)
file #39991:  configmakecheck.txt added by stepheng (109KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by citrin (Posted a comment)
  • -unavailable- added by rockdaboot (Posted a comment)
  • -unavailable- added by stepheng (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Mar 2017 12:51:55 PM UTCrockdabootStatusNone=>Inspected
    Mon 13 Mar 2017 08:53:35 PM UTCstephengAttached File-=>Added test-suite.log, #40001
    Mon 13 Mar 2017 04:35:27 PM UTCstephengAttached File-=>Added test-suite.log, #39993
    Mon 13 Mar 2017 04:34:42 PM UTCstephengAttached File-=>Added bootstrapconfigmakecheck.txt, #39992
    Mon 13 Mar 2017 04:07:46 PM UTCstephengAttached File-=>Added test-suite.log, #39990
      Attached File-=>Added configmakecheck.txt, #39991

    Back to the top


    Powered by Savane 3.1-cleanup1