bugGNU Wget - Bugs: bug #50219, ftp.c calls abort() under certain...

 
 

bug #50219: ftp.c calls abort() under certain error conditions

Submitted by:  Tim Ruehsen <rockdaboot>
Submitted on:  Fri 03 Feb 2017 10:40:55 AM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Open
Release: trunkOperating System: None
Reproducibility: NoneFixed Release: None
Planned Release: NoneRegression: None
Work Required: 1 - DaysPatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 03 Feb 2017 10:40:55 AM UTC, original submission:

A potential long runner like Wget should never call abort().

In src/ftp.c are some switch() with incomplete testing and defaulting to call abort(). This may stop Wget randomly.

Example:
ftp.c, L585+:
err = ftp_syst ...
switch (err)...

'err' may become WRITEFAILED on write errors. This is not cased by the switch and would got into the default case that calls abort().

Solution:
Never call abort(). Instead print a precise error message and return the error to the calling function.

Tim Ruehsen <rockdaboot>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rockdaboot (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1