bugGNU nano - Bugs: bug #49737, two untranslated messages in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #49737: two untranslated messages in browser, one in files

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Tue 29 Nov 2016 04:56:42 PM UTC
   
 
Severity:  2 - Minor Status:  Fixed
Assigned to:  dolorous Open/Closed:  Closed

Thu 01 Dec 2016 12:24:11 PM UTC, comment #5: 

Crap.  The bug number in the commit message was wrong.  :(

Benno Schulenberg <bens>
Group administrator
Thu 01 Dec 2016 12:06:12 PM UTC, comment #4: 

Fixed in git, b5400ff.  Thanks for the patch.

Benno Schulenberg <bens>
Group administrator
Wed 30 Nov 2016 04:31:05 PM UTC, comment #3: 

Okay; thanks for the info, and good eye.  The attached patch fixes these (plus a third message in files.c that I found while going through statusline() calls: "File '%s' is unwritable").

David Lawrence Ramsey <dolorous>
Group Member
Wed 30 Nov 2016 09:53:01 AM UTC, comment #2: 

I had left that "disappeared" message ungettextized on purpose -- I wasn't sure whether I wanted to keep it and didn't want to bother translators with something that soon would go away or change again.  The thing is: it covers a very specific situation that is very unlikey to occur, but it doesn't cover situations of disappearing directories that are more likely.  For example: mkdir aaa, src/nano, ^R ^T M-G aaa <Enter>, in another terminal rmdir aaa, and then in the first terminal type <Enter>: "Error reading /very/long/path/aaa/..: No such file or directory".  This is confusing because the parent dir of aaa still exists, it's just that the current dir and the dotdot entry are gone.  So I was hoping to get the ungettextized message to cover this situation too.

I don't like the fusing of warn_and_shortly_pause() into statusline() -- it makes the later too complicated in my opinion, pausing sometimes before and sometimes after the message, and the "FORCEDALERT" code does not convey what it does: pausing after.

In your second patch, though, there is another message that is ungettextized, and that one looks like a real oversight.  So I will accept a patch that gettextizes those two messages.

Benno Schulenberg <bens>
Group administrator
Tue 29 Nov 2016 07:16:13 PM UTC, comment #1: 

Attached two patches regarding this.

The first is the bare minimum fix of translating the string.

The second, which is on top of the first, is a minor refactor of warn_and_shortly_pause() that moves its functionality into statusline() (which standardizes the message delays and allows for printf-style formatted messages).

(file #39101, file #39102)

David Lawrence Ramsey <dolorous>
Group Member
Tue 29 Nov 2016 04:56:42 PM UTC, original submission:  

In current nano git, do_browse_from() contains the string "The working directory has disappeared" for a statusbar message, but that string isn't translated.

(Also, since that message contains no printf-style special characters, and is followed by a beep and a delay, maybe it could be adapted to use warn_and_shortly_pause()?  Although, in that case, its associated delay would increase from 1200 to to 1800, which I'm not sure is desirable.)

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-12-13 bens Open/ClosedOpen Closed
    2016-12-01 bens StatusNone Fixed
        SummaryUntranslated message in file browser two untranslated messages in browser, one in files
    2016-11-30 dolorous Attached File- Added 0001-browser-files-Properly-gettextize-three-statusbar-me.patch, #39112
    2016-11-30 bens Severity3 - Normal 2 - Minor
        Assigned toNone dolorous
    2016-11-29 dolorous Attached File- Added 0001-browser-Fix-untranslated-message-when-the-working-di.patch, #39101
        Attached File- Added 0002-Refactor-the-functionality-of-warn_and_shortly_pause.patch, #39102

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code