bugGNU nano - Bugs: bug #49511, mistaken screen display when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #49511: mistaken screen display when deleting or inserting stuff with linenumbers in softwrap mode

Submitter:  Anton Minaev <glvertex>
Submitted:  Wed 02 Nov 2016 11:23:54 AM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Jump to the original submission

Tue 13 Dec 2016 11:46:49 AM UTC, comment #11: 

The fix has been released in 2.7.2.

Benno Schulenberg <bens>
Group administrator
Sun 13 Nov 2016 06:22:42 PM UTC, comment #10: 

Fixed in git, 7598b77.

Thanks for reporting.

Benno Schulenberg <bens>
Group administrator
Sun 13 Nov 2016 05:59:08 PM UTC, comment #9: 

Good job, bugs can not be reproduced.
Fixed)

Anton Minaev <glvertex>
Sat 12 Nov 2016 04:01:23 PM UTC, comment #8: 

Thanks for testing, and for the second bug report!  Attached patch should fix both.

(file #38943)

Benno Schulenberg <bens>
Group administrator
Fri 11 Nov 2016 04:27:11 AM UTC, comment #7: 

Thanks for patching.
I applied the better patch and posted bug not reproduce, but found new bug with hide line and bad line numbers, which is also associated with the replacement `COLS' to `editwincols'.

Reproduce:

1. Do bash script:
echo -n > test.txt;for n in 1 2 3; do for i in $(seq 36); do [ "$n" == "2" ] && echo -n "hidden line" >> ./test.txt && break; echo -n "$n" >> test.txt; done; echo >> test.txt; done; stty cols 40 && ./src/nano --ignore --softwrap --linenum ./test.txt
2. Input any character.

String "hidden line" is hidden.

Anton Minaev <glvertex>
Wed 09 Nov 2016 08:24:42 PM UTC, comment #6: 

Attached is a better patch.

(file #38920)

Benno Schulenberg <bens>
Group administrator
Wed 09 Nov 2016 06:34:23 PM UTC, comment #5: 

Here is a proposed patch.  Could you check whether it solves all your issues with linenumbers in softwrap mode?

(file #38917)

Benno Schulenberg <bens>
Group administrator
Mon 07 Nov 2016 09:12:21 PM UTC, comment #4: 

Thanks.  I can now reproduce it and will try and fix it in the coming days.

Benno Schulenberg <bens>
Group administrator
Fri 04 Nov 2016 07:51:23 AM UTC, comment #3: 

I make bash script for simplification bug reproduce.

echo -n > test.txt;for n in 1 2; do for i in $(seq 42); do echo -n "$n" >> test.txt;  done; echo >> test.txt; done; stty cols 40 && ./src/nano --ignore --softwrap --linenum ./test.txt

After running script:
1. Press `End';
2. Press 6 x `Backspace';
3. Press `Down'.

String "22222" is duplicated.

Anton Minaev <glvertex>
Thu 03 Nov 2016 07:33:03 PM UTC, comment #2: 

Thanks for reporting.  However, I cannot reproduce it.  Please try to reproduce while using 'nano --ignore', so that we exclude any other settings that you use.  Then add the options that you mentioned: --nowrap --softwrap --linenum.  And please mention how wide your terminal is, and what you type (is a continuous string of a's enough?), and how far into the second line you type.

(I do see a problem: line number "2" disappears as soon as line 1 softwraps, and that's wrong.  But I can't get a duplicated + uneditable line.)

Benno Schulenberg <bens>
Group administrator
Wed 02 Nov 2016 11:46:17 AM UTC, comment #1: 

UPD:
Reproduce:
1. Run `nano -$ -l -w';


Anton Minaev <glvertex>
Wed 02 Nov 2016 11:23:54 AM UTC, original submission:  

Commit: af0f81f
Bug:
Bad line numbers in front with switch on softwrap.

Reproduce:
1. Run `nano -$ -l';
2. Write two lines, which wider editor;
3. Backspace first line, while it shorter than editor;
4. Press `Down' and `End'.

Wraped part of second line duplicated and its not editable.

Anton Minaev <glvertex>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by glvertex (nano linenum bug)
  • -email is unavailable- added by glvertex (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-12-13 bens Open/ClosedOpen Closed
    2016-11-13 bens StatusIn Progress Fixed
    2016-11-12 bens Attached File- Added 0001-screen-use-the-correct-width-to-determine-whether-a-.patch, #38943
        Summarymistaken screen display when deleting stuff with linenumbers in softwrap mode mistaken screen display when deleting or inserting stuff with linenumbers in softwrap mode
    2016-11-09 bens Attached File- Added 0001-softwrap-refresh-screen-when-a-deletion-might-have-u.patch, #38920
        Summarylinenumbers and softwrap bug mistaken screen display when deleting stuff with linenumbers in softwrap mode
    2016-11-09 bens Attached File- Added refresh-when-backspacing-with-softwrap.patch, #38917
        StatusNone In Progress
    2016-11-07 bens Assigned toNone bens
    2016-11-02 glvertex Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code