GNU nano - Bugs: bug #48388, when the user starts typing during...
You are not allowed to post comments on this tracker with your current authentication level.
bug #48388: when the user starts typing during loading, a byte is dropped
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Sun 03 Jul 2016 11:35:04 AM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Mon 04 Jul 2016 09:43:38 AM UTC, comment #2: |
Benno Schulenberg <bens> |
Sun 03 Jul 2016 12:40:58 PM UTC, comment #1: The offending commit is 31f0456. That'll teach me: not to do a move and a change at the same time. But still: it's a mystery to me how the old version does not lose a byte. Hmmm... Maybe because it looks at the keyboard only after (on average) a second and a half have passed, and precalculation doesn't take that long even on a hundred thousand lines, and thus it never gets anything from the keyboard buffer at all? My version looks at the keyboard immediately -- which is kind of proper, because for the syntaxes that we have, loading a large file takes longer than precalculating the multiline data for it. So when the precalculation starts, already a "long" time has passed, and if the user is impatient, the precalculation should be skipped entirely.
|
Benno Schulenberg <bens> |
Sun 03 Jul 2016 11:35:04 AM UTC, original submission:
To reproduce, open a huge file with nano: 'src/nano hundredthousand.c', and while it loads, immediately type M-G 11.
|
Benno Schulenberg <bens> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-07-30 | bens | Open/Closed | Open | Closed | |
2016-07-04 | bens | Status | In Progress | Fixed | |
2016-07-03 | bens | Status | None | In Progress |
Powered by Savane 3.13-f8d8.
Corresponding source code
The dropping is fixed in git, 29986e9.
For the misrecognizing of "M-G 11", see bug #48395.