bugGnash - The GNU Flash player - Bugs: bug #47248, Old CODECID constants in...

 
 

bug #47248: Old CODECID constants in VideoDecoderFfmpegVaapi.cpp

Submitter:  Rafal Rzepecki <divide>
Submitted:  Thu 25 Feb 2016 12:13:14 AM UTC
   
 
Category:  video-ffmpeg Severity:  3 - Normal
Release:  master Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 25 Feb 2016 08:03:49 AM UTC, comment #1: 

Could you please provide a patch for this ?

Sandro Santilli <strk>
Group Member
Thu 25 Feb 2016 12:13:14 AM UTC, original submission:  

libmedia/ffmpeg/VideoDecoderFfmpegVaapi.cpp uses old style CODECID constants like CODEC_ID_MPEG2VIDEO, which aren't present in newer libav versions, having been replaced by eg. AV_CODEC_ID_MPEG2VIDEO.

In fact gnash already includes polyfills in libmedia/ffmpeg/ffmpegHeaders.h, so just replacing the constants with the new style ones will fix it while still not breaking on older libav headers.

Rafal Rzepecki <divide>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by divide (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-0159.
    Corresponding source code