bugGnash - The GNU Flash player - Bugs: bug #46944, Gnash does not recognize...

 
 

bug #46944: Gnash does not recognize "fscommand:" URI scheme in `MovieClip.getURL()`

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Thu 21 Jan 2016 08:41:45 AM UTC  
 
Category: coreSeverity: 3 - Normal
Release: masterStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 30 Mar 2017 07:54:02 AM UTC, comment #6:

The XFAILED issue about "<>" FSCommand parameter is now reported as bug #50677.

Nutchanon Wetchasit <nachanon>
Fri 24 Feb 2017 02:58:04 PM UTC, comment #5:

The mentioned problem about `undefined` FSCommand parameter is now reported as bug #50393.

Nutchanon Wetchasit <nachanon>
Thu 23 Feb 2017 09:14:13 PM UTC, comment #4:

Thanks for complete test !

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 23 Feb 2017 04:48:18 PM UTC, comment #3:

I confirm that current git version of Gnash is now displaying `mcgeturl-fscommand-*.swf` from `mcgeturl-fscommand.zip` in fullscreen, and not emitting any URL handler errors anymore.

This bug could now be marked as fixed, and I will follow XFAILED issues about `undefined` and "<>" parameter value in separate tickets.

Test runs are summarized as follows:

  • Gnash, out of the box:
    • hostcmd_testrunner_v5: 16 PASSED, 2 XFAILED
    • hostcmd_testrunner_v6: 16 PASSED, 2 XFAILED
    • hostcmd_testrunner_v7: 16 PASSED, 2 XFAILED
    • hostcmd_testrunner_v8: 16 PASSED, 2 XFAILED
    • hostcmd_htmltest_v5.html: 43 PASSED, 3 XFAILED
    • hostcmd_htmltest_v6.html: 43 PASSED, 3 XFAILED
    • hostcmd_htmltest_v7.html: 43 PASSED, 3 XFAILED
    • hostcmd_htmltest_v8.html: 43 PASSED, 3 XFAILED
  • Gnash, with commit e9eb84e reverted:
    • hostcmd_testrunner_v5: 2 PASSED, 2 XFAILED, 14 FAILED
    • hostcmd_testrunner_v6: 2 PASSED, 2 XFAILED, 14 FAILED
    • hostcmd_testrunner_v7: 2 PASSED, 2 XFAILED, 14 FAILED
    • hostcmd_testrunner_v8: 2 PASSED, 2 XFAILED, 14 FAILED
    • hostcmd_htmltest_v5.html: 2 XFAILED, 14 FAILED *
    • hostcmd_htmltest_v6.html: 2 XFAILED, 14 FAILED *
    • hostcmd_htmltest_v7.html: 2 XFAILED, 14 FAILED *
    • hostcmd_htmltest_v8.html: 2 XFAILED, 14 FAILED *
  • Flash Player:
    • hostcmd_htmltest_v5.html: 43 PASSED, 5 XPASSED
    • hostcmd_htmltest_v6.html: 43 PASSED, 5 XPASSED
    • hostcmd_htmltest_v7.html: 43 PASSED, 5 XPASSED
    • hostcmd_htmltest_v8.html: 43 PASSED, 5 XPASSED

Notes:

  • These figures treat "There should be NN tests run" the same way as other checks.
  • In cases marked with asterisk (*), browser shown 16 errors about unimplemented `fscommand` protocol; which is totally expected.

Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Adobe Flash Player: 11.2.202.491 (NPAPI binary)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>
Wed 22 Feb 2017 06:37:33 PM UTC, comment #2:

Should be fixed as of commit:144e0827072b746b2bedebe39ca8a7e0fb43a455

Please test :)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 19 Feb 2017 06:09:05 AM UTC, comment #1:

Patch included, see patch #9264.

After applying this patch, all test SWFs in `mcgeturl-fscommand.zip` should now display in fullscreen (provided that `ignoreFSCommand` in Gnash configuration file is set to `false`); and there would be no unsupported-scheme error message from the external URL handler anymore.

Gnash: 0.8.11dev (patched against git e90fc76 31-Jan-2017)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>
Thu 21 Jan 2016 08:41:45 AM UTC, original submission:

While I was testing repainting condition in bug #27981 using SWFC, I ran
into a problem with Gnash's `MovieClip.getURL()` implementation regarding
FSCommand:

It turned out that while "fscommand:" URI scheme works fine on Gnash via the
built-in `getURL()` function powered by `GETURL2` AVM1 instruction,
it is not recognized in Gnash's `MovieClip.getURL()` method.

On Adobe Flash Player, "fscommand:" URI issued using `MovieClip.getURL()`
works the same as built-in `getURL()`.

I have created test Flash files (Flash 7) using SWFTools's SWFC, libming's
makeswf, and MTASC which tries to issue "fullscreen" FSCommand with "true"
parameter using `MovieClip.getURL("fscommand:fullscreen","true")`, and
run them with `set IgnoreFSCommand false` in `~/.gnashrc` configuration.

This is an image result of `mcgeturl-fscommand.swf` under Adobe Flash Player:
http://i.imgur.com/Ss60C58.png

You'd see that Flash Player recognized the issued FSCommand, and switched to fullscreen mode.

This is an image result of `mcgeturl-fscommand.swf` under Gnash:
http://i.imgur.com/WNWHHU4.png

Gnash's console output shown:

You'd see that Gnash did not recogize the issued FSCommand, and remains in
windowed display. From console output, you'd see that Gnash tried to open
the FSCommand URI via `xdg-open` as if it was a normal URL.

Test SWFs, source code, build script, screenshots, and logs (verbosity 2
+ action error log) are attached as `mcgeturl-fscommand.zip`.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

Note: This is particularly important for SWF generated using SWFC, as SWFC's
ActionScript compiler seems to recognize neither the built-in `getURL()`
instruction nor the `fscommand()` macro; only way for SWFC-based script
to issue FSCommand is doing it via `MovieClip.getURL()`.

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36108:  mcgeturl-fscommand.zip added by nachanon (25KiB - application/zip - Test Flash files, source code, build script, screenshots, and logs)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 23 Feb 2017 09:14:13 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 22 Feb 2017 06:37:33 PM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk
    Thu 21 Jan 2016 08:41:45 AM UTCnachanonAttached File-=>Added mcgeturl-fscommand.zip, #36108

    Back to the top


    Powered by Savane 3.1-cleanup1