bugGnash - The GNU Flash player - Bugs: bug #46219, [Patch] NPAPI plugin with QT GUI...


bug #46219: [Patch] NPAPI plugin with QT GUI disavows XEmbed support

Submitter:  None
Submitted:  Fri 16 Oct 2015 05:08:30 AM UTC
Category:  plugin Severity:  3 - Normal
Release:  master Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup

Fri 16 Oct 2015 05:08:30 AM UTC, original submission:  

...which caused Gnash to not run under my qt4webkit-based browser.
I'm talking about NPPVpluginNeedsXEmbed value for NPP_GetValue(), which is supposed to be TRUE if plugin supports XEmbed. However, the corresponding piece of Gnash code is:

      case NPPVpluginNeedsXEmbed:
#ifdef HAVE_GTK2
          *static_cast<NPBool *>(aValue) = TRUE;
          *static_cast<NPBool *>(aValue) = FALSE;

so for some reason it returns FALSE when GTK+ GUI is not compiled. AFAIK, this is blatant lies, since Gnash supported XEmbed from the beginning and doesn't even offer an alternative.
Anyways, some browsers like Firefox seem to sidestep this, but I use Qupzilla with Qt4 QtWebKit fork, and the latter aborts the init function if windowed plugin denies XEmbed support, leading to cascade of errors and the plugin not working. It's WebKit problem, so other browsers with the same engine are affected too, e.g. Arora.
So, in summary, Gnash didn't work under any Qt4 QtWebKit-based browser without the GTK+ GUI.
The most important point is that after changing the above FALSE to TRUE the plugin works just dandy. Thus, patch attached. I assume the whole #ifdef thing was some misunderstanding, it doesn't really make sense to me.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #35206:  custom.patch added by None (490B - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.


Follows 1 latest change.

Date Changed by Updated Field Previous Value => Replaced by
2015-10-16 None Attached File- Added custom.patch, #35206

Back to the top

Powered by Savane 3.13-b921.
Corresponding source code