bugGnash - The GNU Flash player - Bugs: bug #46219, [Patch] NPAPI plugin with QT GUI...

 
 

bug #46219: [Patch] NPAPI plugin with QT GUI disavows XEmbed support

Submitted by:  None
Submitted on:  Fri 16 Oct 2015 05:08:30 AM UTC  
 
Category: pluginSeverity: 3 - Normal
Release: masterStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 16 Oct 2015 05:08:30 AM UTC, original submission:

...which caused Gnash to not run under my qt4webkit-based browser.
I'm talking about NPPVpluginNeedsXEmbed value for NPP_GetValue(), which is supposed to be TRUE if plugin supports XEmbed. However, the corresponding piece of Gnash code is:
so for some reason it returns FALSE when GTK+ GUI is not compiled. AFAIK, this is blatant lies, since Gnash supported XEmbed from the beginning and doesn't even offer an alternative.
Anyways, some browsers like Firefox seem to sidestep this, but I use Qupzilla with Qt4 QtWebKit fork, and the latter aborts the init function if windowed plugin denies XEmbed support, leading to cascade of errors and the plugin not working. It's WebKit problem, so other browsers with the same engine are affected too, e.g. Arora.
So, in summary, Gnash didn't work under any Qt4 QtWebKit-based browser without the GTK+ GUI.
The most important point is that after changing the above FALSE to TRUE the plugin works just dandy. Thus, patch attached. I assume the whole #ifdef thing was some misunderstanding, it doesn't really make sense to me.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #35206:  custom.patch added by None (490B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follows 1 latest change.

Date Changed By Updated Field Previous Value => Replaced By
Fri 16 Oct 2015 05:08:30 AM UTCNoneAttached File-=>Added custom.patch, #35206

Back to the top


Powered by Savane 3.1-cleanup1