bugGNU Scientific Library - Bugs: bug #45521, Erroneous use of GSL_ERROR_NULL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45521: Erroneous use of GSL_ERROR_NULL instead of GSL_ERROR macro

Submitted by:  Patrick Alken <psa>
Submitted on:  Fri 10 Jul 2015 03:33:02 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Operating System: Status: None
Assigned to: NoneOpen/Closed: Open
Release: 

Fri 10 Jul 2015 03:33:02 PM UTC, original submission:

from matthias =at= familie =dash= sitte =dot= org

Hi list,

in reference to my previous email I dug through the whole code base, checking
each function that the 'git grep -n -p "GSL_ERROR_NULL"' returned. Thankfully,
only a couple of more functions turned up which use GSL_ERROR_NULL instead of
GSL_ERROR. Although this might not seem relevant at first, remember that
GSL_SUCCESS equals to 0 as does NULL returned by GSL_ERROR_NULL, so there's no
way of knowing that those functions might fail if you use a custom error handler
which doesn't automatically abort.

Anyway, patch attached. If you prefer pull requests instead, let me know.

Cheers,

Matthias

Patrick Alken <psa>
Project Administrator

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psa (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 10 Jul 2015 03:33:02 PM UTCpsaAttached File-=>Added fix_erroneous_use_of_gsl_error_null_macro.patch, #34413

    Back to the top


    Powered by Savane 3.1-cleanup1