bugGNU Wget - Bugs: bug #45289, wget -r %3a crashes

 
 

bug #45289: wget -r %3a crashes

Submitted by:  Hackndo <hackndo>
Submitted on:  Wed 10 Jun 2015 07:55:18 AM UTC  
 
Category:  Crash/Freeze/Infloop Severity:  3 - Normal
Priority:  5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  1.16.2 Operating System:  GNU/Linux
Reproducibility:  Every Time Fixed Release:  None
Planned Release:  None Regression:  No
Work Required:  None Patch Included:  Yes

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 15 Jul 2015 04:32:38 PM UTC, comment #5: 

Thanks, patch is in master now (slightly amended).
I classify the patch as trivial (no FSF assignment needed).

Tim Ruehsen <rockdaboot>
Project Administrator
Wed 15 Jul 2015 10:09:28 AM UTC, comment #4: 

It's fine by me !

Hackndo <hackndo>
Wed 15 Jul 2015 09:57:09 AM UTC, comment #3: 

I've tested it and the provided patch solves the issue. Is there anything else we could do to push this forward?

Ander Juaristi <ajuaristi>
Wed 10 Jun 2015 08:51:02 AM UTC, comment #2: 

Hi,

I'm sorry, it's the first time I contribute to something. Hope that this new file is ok. If it's not, please do not hesitate to tell my what is wrong and how I can fix it.

Hackndo <hackndo>
Wed 10 Jun 2015 08:15:41 AM UTC, comment #1: 

Hi,

I see you've made changes, which is highly appreciated, but it would be easier for me to tell exactly what you have changed (and evaluate accordingnly) if you sent them in patch format, rather than the whole source file.

Please send your patch in standard e-mail format. You can do that with `git format-patch`.

Ander Juaristi <ajuaristi>
Wed 10 Jun 2015 07:55:18 AM UTC, original submission:  

recur.c contains
struct url *url_parsed = url_parse (url, &url_err, i, true);

But there are no check for url_parsed being null or not. If null, then later on, in url.c, url->host is called, and a segfault occurs.

Patch attached

Hackndo <hackndo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #34191:  0001-Fix-45289.patch added by hackndo (4KiB - text/x-patch - fix)
file #34190:  recur.c added by hackndo (24KiB - text/x-csrc - Add url_parsed check)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rockdaboot (Posted a comment)
  • -email is unavailable- added by ajuaristi (Posted a comment)
  • -email is unavailable- added by hackndo (Submitted the item)
  •  

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-07-15 rockdaboot StatusNone => Fixed
        Open/ClosedOpen => Closed
    2015-06-10 hackndo Attached File- => Added 0001-Fix-45289.patch, #34191
    2015-06-10 hackndo Attached File- => Added recur.c, #34190

    Back to the top


    Powered by Savane 3.5