bugGnash - The GNU Flash player - Bugs: bug #43867, int overflow

 
 

bug #43867: int overflow

Submitted by:  Joshua Rogers <megamansec3>
Submitted on:  Mon 22 Dec 2014 11:46:38 AM UTC  
 
Category: coreSeverity: 3 - Normal
Release: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 22 Dec 2014 10:41:18 PM UTC, comment #1:

It seems that if such an overflow occurs, and some bogus value is passed to construct_object, eventually Gnash will die with an exception because of too many calls to SafeStack::pop(). As far as I can tell there is no validation of nargs even if its value isn't the result of an overflow.

Bastiaan Jacques <bjacques>
Project Member
Mon 22 Dec 2014 11:46:38 AM UTC, original submission:

Hi,

In ASHandlers.cpp:

2306 unsigned nargs = toNumber(env.pop(), getVM(env));

may cause an int overflow dur to the conversation from 64bits to 32bits

And then it is used:

2325 as_object* newobj = construct_object(constructor, env, nargs);

which will cause problems.

Thanks,

Joshua Rogers <megamansec3>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by megamansec3 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 22 Dec 2014 10:41:18 PM UTCbjacquesCategoryNone=>core
      PrivacyPrivate=>Public

    Back to the top


    Powered by Savane 3.1-cleanup1