bugGnash - The GNU Flash player - Bugs: bug #42574, Gnash building is broken in...

 
 

bug #42574: Gnash building is broken in GnashImageGif.cpp with giflib-5.1

Submitted by:  Frederic Bezies <fredbezies>
Submitted on:  Tue 17 Jun 2014 08:28:39 AM UTC  
 
Category:  build Severity:  3 - Normal
Release:  trunk Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 11 Sep 2014 02:47:27 PM UTC, comment #6: 

Fixed with commit 58dcdd9338d965e54c8f03ce3d2757388d82b7a3

Sandro Santilli <strk>
Project Member
Sun 27 Jul 2014 10:00:18 AM UTC, comment #5: 

As a workaround, you can change line 123 of libbase/GnashImageGif.cpp file as follows:

 GifInput::~GifInput()
 {
     // Clean up allocated data.
-    DGifCloseFile(_gif);
+    DGifCloseFile(_gif, 0);
 }

Behnam Momeni <momeni>
Fri 04 Jul 2014 10:15:10 AM UTC, comment #4: 

Is there a workaround for this in the meantime? I'd really like to compile Gnash for my use, but obviously can't at the moment.

Koz Ross <kozross>
Tue 17 Jun 2014 09:38:45 AM UTC, comment #3: 

Yes, I think we're not as yet compatible with 5.1.

Bastiaan Jacques <bjacques>
Project Member
Tue 17 Jun 2014 09:37:32 AM UTC, comment #2: 

[fred@fredo-arch ~]$ yaourt -Qi giflib
Name                  : giflib
Version               : 5.1.0-1

So a bug related to giflib 5.1.0 ?

Frederic Bezies <fredbezies>
Tue 17 Jun 2014 09:35:16 AM UTC, comment #1: 

What version of giflib are you building against?

Bastiaan Jacques <bjacques>
Project Member
Tue 17 Jun 2014 08:28:39 AM UTC, original submission:  

For a few days, gnash building is broken with gcc 4.9.0.

Here is the error log :

  CXX      libgnashbase_la-GnashImageGif.lo
GnashImageGif.cpp: In destructor 'virtual
gnash::image::{anonymous}::GifInput::~GifInput()':
GnashImageGif.cpp:123:23: error: too few arguments to function 'int
DGifCloseFile(GifFileType*, int*)'
     DGifCloseFile(_gif);
                       ^
In file included from GnashImageGif.cpp:27:0:
/usr/include/gif_lib.h:183:9: note: declared here
     int DGifCloseFile(GifFileType * GifFile, int *ErrorCode);
         ^
Makefile:1257: recipe for target 'libgnashbase_la-GnashImageGif.lo'
failed
make[2]: *** [libgnashbase_la-GnashImageGif.lo] Error 1
make[2]: Leaving directory
'/mnt/tmp/aur/gnash-trunk-git/src/gnash/libbase'
Makefile:1145: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/mnt/tmp/aur/gnash-trunk-git/src/gnash'
Makefile:1052: recipe for target 'all' failed
make: *** [all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

Last time I had a full build process was on june 4th. Didn't made another one since that day. So a commit is breaking build process after june 4th.

Frederic Bezies <fredbezies>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by momeni (Posted a comment)
  • -email is unavailable- added by kozross (Posted a comment)
  • -email is unavailable- added by bjacques (Posted a comment)
  • -email is unavailable- added by fredbezies (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-11 strk StatusNone => Fixed
        Open/ClosedOpen => Closed
    2014-06-17 bjacques SummaryGnash building is broken in GnashImageGif.cpp with gcc 4.9.0 => Gnash building is broken in GnashImageGif.cpp with giflib-5.1

    Back to the top


    Powered by Savane 3.7