bugGNU Zile (Zile implements Lua Editors) - Bugs: bug #41257, isearch is very slow in zmacs

 
 

bug #41257: isearch is very slow in zmacs

Submitted by:  Reuben Thomas <rrt>
Submitted on:  Thu 16 Jan 2014 11:50:42 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Status: FixedAssigned to: Gary V. Vaughan <gary>
Open/Closed: ClosedRelease: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Mar 2014 02:34:12 AM UTC, comment #4:

Sure, there's a ton of optimizations and simplifications which look like good candidates to port over. The difficult part is figuring out whether they still apply to the multi-window/multi-buffer/host-line-endings capable files still in the main Zile tree.

That said, if the boundaries between Zile modules and editor implementation are drawn in the right place, then Zee should be the simplest possible editor available by gluing together Zile modules and adding I/O. So a proper application of your good stuff from Zee to the Zile tree is to back port everything and move the boundaries around so that all unnecessary complications are a factor of a particular editor implementation rather than an artifact of the Zile modules it uses.

It's far from a small or straight forward task though, so I don't see any advantage in your trying to catalogue the particulars retroactively... when a large helping of patience will bring everything along in due course anyway :)

Gary V. Vaughan <gary>
Project AdministratorIn charge of this item.
Thu 06 Mar 2014 11:24:08 AM UTC, comment #3:

I must admit I hadn't realised there was a lot of useful stuff in the Zee tree; sorry! After all, I catalogued stuff worth porting from C Zile; with Zee I was much more slap-dash about the organization of commits, as it was an experimental, private project. Maybe that'll teach me…

If you can give me any hints, then maybe I can help document what is worth pulling out?

Reuben Thomas <rrt>
Project Administrator
Thu 06 Mar 2014 02:35:14 AM UTC, comment #2:

Done: Sorry for the delay.

See @b783e9c.

The last time I tried to fix this I stalled on a lack of memrchr() on Mac OS, and then got sidetracked into porting a selection of dependent changes and efficiency improvements.

There's actually still a lot of good stuff in the Zee tree that needs porting back into the Zile tree, but much of it is hidden in commits with names like "a big wodge of changes", so separating out self contained changesets is not straight forward. Although I've teased apart quite a few already.

I think the best way forward from here is to port over anything one of us notices as worth doing as and when, but to wait until Zee is reintegrated into the new multi-editor Zile tree to pick up the other hard to extract improvements.

Gary V. Vaughan <gary>
Project AdministratorIn charge of this item.
Sat 01 Mar 2014 10:16:01 AM UTC, comment #1:

Note that this is fixed in Zee; the fix should be portable.

Reuben Thomas <rrt>
Project Administrator
Thu 16 Jan 2014 11:50:42 PM UTC, original submission:

Inherited from Lua Zile, mea culpa.

Reuben Thomas <rrt>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gary (Posted a comment)
  • -unavailable- added by rrt (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 06 Mar 2014 02:36:43 AM UTCgaryOpen/ClosedOpen=>Closed
    Thu 06 Mar 2014 02:35:14 AM UTCgaryStatusNone=>Fixed
      Assigned toNone=>gary

    Back to the top


    Powered by Savane 3.1-cleanup