bugGNU MIX Development Kit - Bugs: bug #40359, mdk-1.2.7/mixlib/xmix_vm.c:442:...

 
 

bug #40359: mdk-1.2.7/mixlib/xmix_vm.c:442: possible bad if test ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Thu 24 Oct 2013 08:38:02 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Jose Antonio Ortega Ruiz <jao>
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Oct 2013 05:59:05 PM UTC, comment #1: 

You're absolutely right, David.  I've pushed a patch to the repo that fixes the problem as you suggest.

Thanks!

Jose Antonio Ortega Ruiz <jao>
Project AdministratorIn charge of this item.
Thu 24 Oct 2013 08:38:02 AM UTC, original submission:  

Source code is

  g_assert (ins->opcode >= mix_opJAx || ins->opcode <= mix_opJXx);

Suggest swap || for &&

gcc compiler flag -Wlogical-op said

xmix_vm.c:442:3: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jao (Posted a comment)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-08-05 jao Open/ClosedOpen => Closed
    2013-10-24 jao StatusNone => Fixed
        Assigned toNone => jao

    Back to the top


    Powered by Savane 3.7