bugGNU MIX Development Kit - Bugs: bug #40359, mdk-1.2.7/mixlib/xmix_vm.c:442:...

 
 

bug #40359: mdk-1.2.7/mixlib/xmix_vm.c:442: possible bad if test ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Thu 24 Oct 2013 08:38:02 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Jose Antonio Ortega Ruiz <jao>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Oct 2013 05:59:05 PM UTC, comment #1:

You're absolutely right, David. I've pushed a patch to the repo that fixes the problem as you suggest.

Thanks!

Jose Antonio Ortega Ruiz <jao>
Project AdministratorIn charge of this item.
Thu 24 Oct 2013 08:38:02 AM UTC, original submission:

Source code is

g_assert (ins->opcode >= mix_opJAx || ins->opcode <= mix_opJXx);

Suggest swap || for &&

gcc compiler flag -Wlogical-op said

xmix_vm.c:442:3: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jao (Posted a comment)
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 05 Aug 2014 12:37:26 AM UTCjaoOpen/ClosedOpen=>Closed
    Thu 24 Oct 2013 05:59:05 PM UTCjaoStatusNone=>Fixed
      Assigned toNone=>jao

    Back to the top


    Powered by Savane 3.1-cleanup