bugGNU FreeIPMI - Bugs: bug #40076, Does not differentiate between...

 
 

bug #40076: Does not differentiate between different OEM-SEL record types

Submitter:  Rob Swindell <rswindell>
Submitted:  Sat 21 Sep 2013 01:40:30 AM UTC
   
 
Category:  ipmi-sel Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Improper Behaviour
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 23 Sep 2013 04:46:54 PM UTC, comment #2: 

How about the attached patch oem_sel_type.new.  Following the output of other fields, I output the record type under very verbose output for ipmi-sel.  So the output will be like

OEM defined = ...

under normal

OEM defined (record type = ...) = ...

for very verbose.

(file #29203)

Albert Chu <chu11>
Group administrator
Mon 23 Sep 2013 04:18:03 PM UTC, comment #1: 

Sounds like a good idea.  Although I think I will slightly change the text.  Should be in the next release.

I would love to see contributions to FreeIPMI to be able to parse these OEM records natively :-)

Albert Chu <chu11>
Group administrator
Sat 21 Sep 2013 01:40:30 AM UTC, original submission:  

OEM-SEL entries may have types from 0xC0 through 0xFF, but the ipmi-sel program just output "OEM defined", not differentiating between the different potential OEM-defined record types.

This patch displays the actual 'record type' value for OEM-defined SEL entries. This allows parsers to differentiate between OEM type 0xE0 and 0xE1 for example and interpet the OEM-defined entry data accordingly.

Example ipmi-sel output from before the patch:

3  | N/A         | N/A      | N/A             | N/A                         | OEM defined = DEh CEh 3Ch 52h 01h 00h 00h 39h 00h 00h 04h 05h 00h

Example ipmi-sel output from after the patch:

3  | N/A         | N/A      | N/A             | N/A                         | OEM E4h defined = DEh CEh 3Ch 52h 01h 00h 00h 39h 00h 00h 04h 05h 00h

If you prefer to put the record-type in parenthesis or after the word "defined", that would be fine too, but tools which parse OEM-defined entries the output of ipmi-sel will need to know the exact record type value.

Rob Swindell <rswindell>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29203:  oem_sel_type.new added by chu11 (805B - application/octet-stream)
file #29188:  oem_sel_type.patch added by rswindell (571B - text/plain - Patch created with "svn diff" which addresses the issue described.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by chu11 (Posted a comment)
  • -email is unavailable- added by rswindell (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-09-25 chu11 Open/ClosedOpen Closed
    2013-09-23 chu11 Attached File- Added oem_sel_type.new, #29203
    2013-09-21 rswindell Attached File- Added oem_sel_type.patch, #29188

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code