bugGnash - The GNU Flash player - Bugs: bug #38705, trace() output became...

 
 

bug #38705: trace() output became indistinguishable from gnash's internal DEBUG log

Submitted by:  Nachanon Vetjasit <nachanon>
Submitted on:  Thu 11 Apr 2013 03:05:48 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: masterStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 25 Jun 2013 04:29:23 PM UTC, comment #9:

all internal debugs are now on the DEBUG channel, including the ones for function enter/exit events. TRACE is reserved for trace() calls.

Sandro Santilli <strk>
Project Member
Tue 25 Jun 2013 04:28:27 PM UTC, comment #8:

Sorry, my tests weren't good. After better testing 090eee0 is the new fix for this.

Sandro Santilli <strk>
Project Member
Tue 25 Jun 2013 03:38:15 PM UTC, comment #7:

Well, I tried and it seems good to me.
Gabriele: feel free to reopen if you see anything broken.

Sandro Santilli <strk>
Project Member
Tue 25 Jun 2013 03:34:31 PM UTC, comment #6:

I've been pointed out that this needs to be re-checked after my commit

Sandro Santilli <strk>
Project Member
Tue 25 Jun 2013 03:21:27 PM UTC, comment #5:

Fixed again with 9ed128df862f00c94a0591c83faafcb1cdf7fc59

Sandro Santilli <strk>
Project Member
Tue 25 Jun 2013 02:53:27 PM UTC, comment #4:

Broken again with c9c178678d01380a26339f160ed7464bcb0d6519 ?
See bug #39338

Sandro Santilli <strk>
Project Member
Fri 12 Apr 2013 07:09:40 PM UTC, comment #3:

Fixed as of edf5c984b3754c966f5ac01d99d25a043e53d970.

Rob Savoye <rsavoye>
Project Administrator
Fri 12 Apr 2013 06:47:22 PM UTC, comment #2:

You're right it's wrong to use log_trace for anything but player trace output. The error was introduced in this commit: e3b571b53dcb6ddf71a754837bc82caaea939da1

Benjamin Wolsey <bwy>
Project Member
Fri 12 Apr 2013 07:57:09 AM UTC, comment #1:

My markup on the original submission was messed up a bit,
I also attached log files (0.8.10 V.S. 7d28e20f) for difference comparison.

(file #27850, file #27851)

Nachanon Vetjasit <nachanon>
Thu 11 Apr 2013 03:05:48 AM UTC, original submission:

As I moved from 0.8.10 to recent git snapshot (7d28e20f),
I began to notice something was emitted in TRACE level from logging verbosity 2
but it's not an output from my SWF's trace():

8211:1] 113 TRACE: gnash::GtkAggGlue::GtkAggGlue() enter
8211:1] 113 TRACE: gnash::GtkAggGlue::GtkAggGlue() returning
8211:1] 113 TRACE: virtual bool gnash::GtkAggGlue::init(int, char***) enter
8211:1] 113 TRACE: virtual bool gnash::GtkAggGlue::init(int, char***) returning
8211:1] 124 TRACE: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*) enter *
8211:1] 124 TRACE: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*) returning *
8211:1] 124 TRACE: virtual gnash::Renderer gnash::GtkAggGlue::createRenderHandler() enter*
8211:1] 126 TRACE: virtual gnash::Renderer gnash::GtkAggGlue::createRenderHandler() returning*
8211:1] 126 TRACE: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int) enter
8211:1] 126 TRACE: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int) returning
8211:1] 131 SECURITY: Extensions disabled
8211:2] 132 UNIMPLEMENTED: FileAttributes tag in the SWF requests that network access is not granted to this movie (or application?) when loaded from the filesystem. Anyway Gnash won't care; use white/black listing in your .gnashrc instead
8211:1] 133 TRACE: void gnash::Gui::resize_view(int, int) enter
8211:1] 133 TRACE: void gnash::Gui::resize_view(int, int) returning
8211:1] 135 TRACE: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int) enter
8211:1] 135 TRACE: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int) returning
8211:1] 135 TRACE: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int) enter
8211:1] 135 TRACE: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int) returning
8211:1] 136 TRACE: void gnash::Gui::resize_view(int, int) enter
8211:1] 136 TRACE: void gnash::Gui::resize_view(int, int) returning
8211:1] 225 TRACE: callee: load
8211:1] 225 TRACE: callee: finished loading
8211:1] 225 TRACE: callee: first run
8211:1] 225 TRACE: callee: external initializing
8211:1] 226 TRACE: callee: adding callback
8211:1] 226 TRACE: callee: finished first run
8211:1] 317 TRACE: status: load
8211:1] 317 TRACE: status: finished loading
8211:1] 317 TRACE: status: load
8211:1] 317 TRACE: status: finished loading
8211:1] 2621 TRACE: bool gnash::movie_root::processInvoke(gnash::ExternalInterface::invoke_t*) enter *
8211:1] 2621 TRACE: bool gnash::movie_root::processInvoke(gnash::ExternalInterface::invoke_t*) returning *

It seems that some lines of Gnash's internal (formerly-)DEBUG message
came out as a TRACE message, mixing up with SWF's trace() output.

This causes inconvenience as one would need to read the whole line
to decide whether each one is SWF's trace() output,
and it cannot be done automatically.

The fix would be either reverting the logging system back to 0.8.10-style
or provide a new means of distinguishing trace() output from gnash's internals debug,
since the old "grep TRACE:" became not as useful.

Note: output above was obtained from my test case on
ExternalInterface problem (bug #37223 js2flash.html)
with gnash logging verbosity 2 (equivalent to gnash -vv)

Gnash: 0.8.11dev (master-21708-7d28e20)
Browser: iceweasel 3.0.6-3 from Debian repository (no addons)
System: Debian GNU/Linux 5.0 Lenny i386

Nachanon Vetjasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27850:  iceweasel3.0-gnash0.8.10-js2flash.log.txt added by nachanon (4kB - text/plain - Log files (verbosity 2) from Gnash 0.8.10 and 0.8.11dev-7d28e20f)
file #27851:  iceweasel3.0-gnash7d28e20f-js2flash.log.txt added by nachanon (2kB - text/plain - Log files (verbosity 2) from Gnash 0.8.10 and 0.8.11dev-7d28e20f)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by rsavoye (Updated the item)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 25 Jun 2013 03:38:15 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 25 Jun 2013 03:34:31 PM UTCstrkStatusFixed=>Ready For Test
      Open/ClosedClosed=>Open
    Tue 25 Jun 2013 03:21:27 PM UTCstrkStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Tue 25 Jun 2013 02:53:27 PM UTCstrkStatusFixed=>Confirmed
      Open/ClosedClosed=>Open
    Fri 12 Apr 2013 07:09:40 PM UTCrsavoyeStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 12 Apr 2013 06:47:22 PM UTCbwyStatusNone=>Confirmed
    Fri 12 Apr 2013 07:57:09 AM UTCnachanonAttached File-=>Added iceweasel3.0-gnash0.8.10-js2flash.log.txt, #27850
      Attached File-=>Added iceweasel3.0-gnash7d28e20f-js2flash.log.txt, #27851

    Back to the top


    Powered by Savane 3.1-cleanup