bugGnash - The GNU Flash player - Bugs: bug #31816, HAVE_LTDL is not guaranteed to be...

 
 

bug #31816: HAVE_LTDL is not guaranteed to be defined when extensions are built

Submitter:  Sandro Santilli <strk>
Submitted:  Tue 07 Dec 2010 03:49:39 PM UTC
   
 
Category:  build Severity:  4 - Important
Release:  None Status:  Fixed
Privacy:  Public Assigned to:  rsavoye
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 20 Dec 2010 11:04:13 PM UTC, comment #12: 

Fixed by eed8d21f6f01112433007ecc77a3171b89801a4f

Sandro Santilli <strk>
Group Member
Mon 20 Dec 2010 04:08:26 PM UTC, comment #11: 

Can't fix a bug which is closed no ?
Setting to Important (being a regression) till we get an agreement on the meaning of "Blocker".

It'd be stupid to not have this one show up when looking for things to do before next release...

Sandro Santilli <strk>
Group Member
Mon 20 Dec 2010 02:47:56 PM UTC, comment #10: 

If you change the bug severity again, you will loose write access to savannah. Leave this alone, and it will get fixed.

Rob Savoye <rsavoye>
Group administrator
Mon 20 Dec 2010 02:44:50 PM UTC, comment #9: 

Please don't be kiddish.
It has nothing to do with buildbot.
Before 06907b931859501ae1daf193d1c1576aecda1124 HAVE_LTDL was not used in the code...

Sandro Santilli <strk>
Group Member
Mon 20 Dec 2010 02:35:38 PM UTC, comment #8: 

Don't ever change the severity on a bug report after I've changed it. This is not a blocker. The patch works fine by hand, it's obviously buildbot is doing something else that breaks this.

Rob Savoye <rsavoye>
Group administrator
Mon 20 Dec 2010 02:32:09 PM UTC, comment #7: 

It's blocker (both release-blocker and regression).
Note there are two slave faling (both lenny based)

Sandro Santilli <strk>
Group Member
Mon 20 Dec 2010 02:28:30 PM UTC, comment #6: 

I've been fixing many other issues since then. If you hadn't started reverting all my revno.h commits, I'd have fixed this yet again too. As the patch is, it did fix OpenBSD too...Note that it worked fine in all my testing, it's just when run under buildbot there is a problem.

Rob Savoye <rsavoye>
Group administrator
Mon 20 Dec 2010 02:23:44 PM UTC, comment #5: 

Rob, the problem is still there, 13 days after you introduced it.

How long "reasonable time" is ? (reguarding http://wiki.gnashdev.org/CommitRules)

Sandro Santilli <strk>
Group Member
Sat 11 Dec 2010 11:10:42 PM UTC, comment #4: 
Sandro Santilli <strk>
Group Member
Sat 11 Dec 2010 11:09:24 PM UTC, comment #3: 

Rob, did you mention this was fixed ?

Sandro Santilli <strk>
Group Member
Tue 07 Dec 2010 04:29:07 PM UTC, comment #2: 

We should be ignoring all system installation of libltdl, as we include libltdl 2.x in the source tarball. We should only be using the internal copy of libltdl, and HAVE_LTDL should be reliable. Maybe we shoudn't look for the libtool version in configure, since we know we only want 2.x.

Rob Savoye <rsavoye>
Group administrator
Tue 07 Dec 2010 04:12:42 PM UTC, comment #1: 

For the record, the problem arises on systems with libtool 1:

checking For the version of libtool... 1.x

Sandro Santilli <strk>
Group Member
Tue 07 Dec 2010 03:49:39 PM UTC, original submission:  

Commit 06907b931859501ae1daf193d1c1576aecda1124 introduced use of HAVE_LTDL to switch whether or not ltdl library was built but that's not correct as there are systems on which the macro isn't defined but still ltdl library is being used (either the internal or external ones).

Example is http://gnashdev.org:8010/builders/lenny-linux-x86/builds/23/

Check configuration step, when extensions are requested.
The resulting gnashconfig.h has no HAVE_LTDL define.

Check test step, extensions loading fails (the FileIO tests)

BTW, does it make sense to disable ltdl implicitly like that ?
It'll strike back if someone builds gnash extensions outside of the gnash tree...

Sandro Santilli <strk>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rsavoye (Updated the item)
  • -email is unavailable- added by strk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-12-20 strk StatusInvalid Fixed
        Open/ClosedOpen Closed
    2010-12-20 strk Severity2 - Minor 4 - Important
        Open/ClosedClosed Open
    2010-12-20 rsavoye Severity5 - Blocker 2 - Minor
        StatusConfirmed Invalid
        Open/ClosedOpen Closed
    2010-12-20 strk Severity3 - Normal 5 - Blocker
    2010-12-20 rsavoye Severity5 - Blocker 3 - Normal
    2010-12-20 strk Severity3 - Normal 5 - Blocker
    2010-12-20 rsavoye Severity5 - Blocker 3 - Normal
    2010-12-11 strk StatusReady For Test Confirmed
    2010-12-11 strk StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code