bugGnash - The GNU Flash player - Bugs: bug #31594, gravity_embedded-TestRunner...

 
 

bug #31594: gravity_embedded-TestRunner testsuite test fail some times

Submitter:  Petter Reinholdtsen <pere>
Submitted:  Tue 09 Nov 2010 08:29:59 AM UTC
   
 
Category:  testsuite Severity:  3 - Normal
Release:  master Status:  Fixed
Privacy:  Public Assigned to:  strk
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 16 Nov 2010 07:43:51 PM UTC, comment #5: 

Thanks for testing!

Sandro Santilli <strk>
Group Member
Tue 16 Nov 2010 07:24:08 PM UTC, comment #4: 

I tested the patch with four builds in a row.  all of them succeeded, while it used to fail every second time.  I guess it work. :)

Petter Reinholdtsen <pere>
Group Member
Tue 16 Nov 2010 06:57:28 PM UTC, comment #3: 

For the record:
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=22a70dc0672b85a0fb83d28e6cb2bd6db0252f96

/me wonders if there's an automatic link to there, somehow

Sandro Santilli <strk>
Group Member
Tue 16 Nov 2010 06:56:23 PM UTC, comment #2: 

I've pushed the (non-definitive) improvement (commit 22a70dc)

Sandro Santilli <strk>
Group Member
Tue 16 Nov 2010 06:14:27 PM UTC, comment #1: 

The test runner sleeps 5milliseconds and does a single advance, expecting the movie to be loaded by that time.
I've sent a patch to pere for testing. The patch makes 5 advances and 1ms sleep each.

Generally, to avoid timing issues, the runner should instead just
periodically check for the existance of a 'ball' children in the loaded-to container and proceed when that is available...

Sandro Santilli <strk>
Group Member
Tue 09 Nov 2010 08:29:59 AM UTC, original submission:  

The test suite fail some times with this error.  I was told on IRC that this is because of race conditions in the thread handling of this test.

 --=[ testsuite/movies.all ]=--
FAIL: gravity_embedded-TestRunner: tmp.strictly_equals(50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:79]
FAIL: gravity_embedded-TestRunner: loaded->getBounds().height() == '0' (expected: 2056) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:81]
FAIL: gravity_embedded-TestRunner: loaded->getBounds().width() == '0' (expected: 2056) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:82]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == '' (expected: 50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:90]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == '' (expected: 50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:98]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:100]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:102]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:104]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:106]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:108]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:110]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:112]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:114]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 44) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:116]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 44) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:118]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 44) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:120]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 44) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:126]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:128]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:130]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:132]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 46) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:134]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:136]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:138]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:140]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 48) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:142]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:144]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:146]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:148]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 50) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:150]
FAIL: gravity_embedded-TestRunner: string(text->get_text_value()) == 'NaN' (expected: 52) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:152]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 52) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:154]
FAIL: gravity_embedded-TestRunner: round(toNumber(tmp, vm)) == '100' (expected: 52) [/var/tmp/gnash/gnashgit/testsuite/movies.all/gravity_embedded-TestRunner.cpp:156]

make[5]: * [anal] Error 1
make[5]: Leaving directory `/var/tmp/gnash/gnashgit/_build'
make[4]: * [check-local] Error 2

Petter Reinholdtsen <pere>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by pere (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-11-16 strk StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2010-11-16 strk StatusIn Progress Ready For Test
        Assigned toNone strk
    2010-11-16 strk StatusNone In Progress

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code