bugGuile - Bugs: bug #30167, libguile/Makefile.am ugly

 
 

bug #30167: libguile/Makefile.am ugly

Submitted by:  Thien-Thi Nguyen <ttn>
Submitted on:  Thu 17 Jun 2010 12:42:17 PM UTC  
 
Category:  None Severity:  2 - Minor
Item Group:  None Status:  Invalid
Privacy:  Public Assigned to:  Thien-Thi Nguyen <ttn>
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 17 Jun 2010 01:16:52 PM UTC, comment #1: 

Actually, both those files are indeed checked, so this is really a non-bug!  (Nice mini-rant there, however...)

Changing the title.

Thien-Thi Nguyen <ttn>
Project MemberIn charge of this item.
Thu 17 Jun 2010 12:42:17 PM UTC, original submission:  

In libguile/Makefile.am, the awk script guile-func-name-check is not being applied to pairs.c and memoize.c because those files are not derivable from the *DOT_DOC_FILES variables.  This incomplete coverage ensures ignorance of (possible, future) func-name bugs there, which is undesirable.

Running the check manually on those files produces spurious warnings (false positives), which is probably one reason why they were omitted in the first place.

There are some related infelicities surrounding this situation:

1/ The awk script is run in the .c.doc pattern rule.  Is that really necessary?  It's a static check -- why not move it some dedicated target, like "make function-name-check", that can be called less frequently (by maintainers)?  See 3/ below.

2/ The long lists of mostly-redundant filenames is bug-prone.  Better to restructure the groupings additively and make use of Automake support for $(VAR:OLD=NEW) syntax.

3/ It's awk.  That is an affront to my scheming sensibilities.
The doc extraction/processing flow tail already uses Scheme, why not the nose, as well?!

Thien-Thi Nguyen <ttn>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by civodul (Updated the item)
  • -email is unavailable- added by ttn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-04-26 civodul StatusNone => Invalid
        Open/ClosedOpen => Closed
    2010-06-17 ttn Summaryfunc-name (#define FUNC_NAME) check not applied fully => libguile/Makefile.am ugly

    Back to the top


    Powered by Savane 3.5