bugGNU Scientific Library - Bugs: bug #29783, Missing cast on line 226 of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #29783: Missing cast on line 226 of glfixed.c?

Submitter:  Michael Forbes <mforbes>
Submitted:  Wed 05 May 2010 01:05:41 AM UTC
   
 
Category:  Build Severity:  3 - Normal
Operating System:  Status:  Fixed
Assigned to:  rhysu Open/Closed:  Closed
Release:  1.14

Thu 06 May 2010 02:43:58 PM UTC, comment #5: 

Patch applied in
commit 1a4cf5e08da41f19c0f0af7a108779fccfc34148

Rhys Ulerich <rhysu>
Group administrator
Thu 06 May 2010 02:04:44 AM UTC, comment #4: 

Glad the patch looks okay.  Issue can be closed once the patch is incorporated.  I lack the ability to changes the status fields (I think).

Go ahead and file the warnings so they're on record.  As for the failed checks, what optimization level and compiler did you use?  Intel's compilers don't tend to pass the GSL tests for things much beyond -O1, and sometimes not even -O1.

Rhys Ulerich <rhysu>
Group administrator
Thu 06 May 2010 12:34:09 AM UTC, comment #3: 

Compiles fine now.

There were some failed checks (see attached check.log).

Also, some warnings were issued:


-bash-3.00$ make -k check > make_check.log
test_gbmv.c(27): warning #188: enumerated type mixed with another type
     cblas_sgbmv(order, trans, M, N, KU, KL, alpha, A,                                  lda, X, incX, beta, Y, incY);
                 ^

test_gbmv.c(27): warning #188: enumerated type mixed with another type
     cblas_sgbmv(order, trans, M, N, KU, KL, alpha, A,                                  lda, X, incX, beta, Y, incY);
                        ^

test_gbmv.c(53): warning #188: enumerated type mixed with another type
     cblas_sgbmv(order, trans, M, N, KU, KL, alpha, A,                                  lda, X, incX, beta, Y, incY);
                 ^


Let me know if I should submit these as a bug too.


(file #20459)

Michael Forbes <mforbes>
Wed 05 May 2010 10:32:02 PM UTC, comment #2: 

Attached is a quick patch to add the cast.  Build and make check pass cleanly on GCC 4.2.4.  Would you please confirm it's good on your Intel version?

(file #20456)

Rhys Ulerich <rhysu>
Group administrator
Wed 05 May 2010 10:22:18 PM UTC, comment #1: 

I just double checked trunk.  Appears line 226 is the only place such a cast fails to appear for either a malloc or a calloc call.

Rhys Ulerich <rhysu>
Group administrator
Wed 05 May 2010 01:05:41 AM UTC, original submission:  

I was having a problem building the gsl using the intel compiler.

icpc (ICC) 10.1 20071116
Copyright (C) 1985-2007 Intel Corporation.  All rights reserved.

because of a lack of cast on line 226 of integration/glfixed.c.  Adding the cast allowed the compilation to continue:


226c226
<       retval = malloc(sizeof(gsl_integration_glfixed_table));
---
>       retval = (gsl_integration_glfixed_table *) malloc(sizeof(gsl_integration_glfixed_table));



Michael Forbes <mforbes>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20459:  check.log added by mforbes (95KiB - application/octet-stream)
file #20456:  glfixed.malloc.cast.patch added by rhysu (473B - text/x-diff - Tentative patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rhysu (Posted a comment)
  • -email is unavailable- added by rhysu
  • -email is unavailable- added by mforbes (Submitted the item)
  •  

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-05-06 rhysu StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2010-05-06 bjg StatusNone Confirmed
        Assigned toNone rhysu
    2010-05-06 mforbes Attached File- Added check.log, #20459
    2010-05-05 rhysu Attached File- Added glfixed.malloc.cast.patch, #20456
    2010-05-05 rhysu Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code