bugGNU Wget - Bugs: bug #28890, Force retry if rate drops below...

 
 

bug #28890: Force retry if rate drops below some threshold

Submitted by:  larytet <larytet>
Submitted on:  Sat 13 Feb 2010 07:44:26 PM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 5 - NormalStatus: In Progress
Privacy: PublicAssigned to: Giuseppe Scrivano <gscrivano>
Originator Name: Open/Closed: Open
Release: 1.12Operating System: GNU/Linux
Reproducibility: NoneFixed Release: None
Planned Release: NoneRegression: No
Work Required: NonePatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 27 May 2010 12:41:38 PM UTC, comment #6:

RE FSF: I read some material on GNU.org. To simplify the matters I suggest that you take the ownership over the patch. I will remove the code from Assembla.

larytet <larytet>
Thu 27 May 2010 12:38:27 PM UTC, comment #5:

my, i have forgot about the whole issue. by the way the problem still exists with my ISP.

What is FSF?

Feel free to use the patch as you wish. GPL/LGPL whatever. I do not care about copyright. If you think the patch can be improved let me know I will try to bring it closer to the production quality.

Thank you.

larytet <larytet>
Thu 27 May 2010 12:26:53 PM UTC, comment #4:

the patch looks fine, with some small adjustments.

Do you have copyright assignments to the FSF?

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Fri 19 Feb 2010 09:05:10 PM UTC, comment #3:

Any chance for the patch to enter the main stream ? I temporary forked Wget 1.12 and added yet another command line option which allows to force restart periodically.

The fork is here https://www.assembla.com/spaces/wgetplus
I hope my patch will help somebody to work around misconfigured traffic shapers as was my case.

regards.

larytet <larytet>
Sun 14 Feb 2010 02:11:11 PM UTC, comment #2:

For the guys behind Proxy not allowing GIT access
full source from SVN http://svn2.assembla.com/svn/wgetplus

larytet <larytet>
Sat 13 Feb 2010 07:49:51 PM UTC, comment #1:

The full patched code and history of changes can be pulled from here
git@git.assembla.com:wgetplus.git

larytet <larytet>
Sat 13 Feb 2010 07:44:26 PM UTC, original submission:

It looks that my ISP started to traffic shape the connection. It works like this:
- Using --limit-rate I specify maximum upload speed 75K (from 95K available). This is the only application accessing Internet.
- For approximately 10 minutes the wget works just fine and pulls at 75K/s. After that the rate drops to 30K/s. The drop is fast, looks like lights went off. I did not check in the sniffer what is going on, but I suspect that I will see dropped packets and TCP retransmissions.
- If I restart wget for the same file it returns to download at 70K/s for 10 minutes more.

This is not an issue with the server. I tried very fast servers including pulling Eclipse from Amazon cloud, rapidshare etc. The servers which usually saturated my downstream.

I patched the version 1.12 - see attached.

I did the patch in 1.12 (see end of the e-mail). I have added option and run the patched version for about 48 hours already. The patch can come handy if the target can be downloaded from different mirrors and the current server slows down for some reason.

Now my patch is rather ugly - i drop the connection by returning from fd_read_body() with negative return code. Still probably somebody will find it useful until there is official support for the feature. The full source code can be downloaded (GIT)
git clone git://git.assembla.com/wgetplus.git

If you think that the patch can be improved and eventually go into official release, than please, let me know. I will try to fix it.

larytet <larytet>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19697:  diff_wget_1.12 added by larytet (5KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by abacabadabacaba
  • -unavailable- added by gscrivano (Posted a comment)
  • -unavailable- added by larytet (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Jun 2016 01:48:01 PM UTCabacabadabacabaCarbon-Copy-=>Added abacabadabacaba
    Thu 27 May 2010 12:26:53 PM UTCgscrivanoStatusNone=>In Progress
      Assigned toNone=>gscrivano
    Sat 13 Feb 2010 07:44:26 PM UTClarytetAttached File-=>Added diff_wget_1.12, #19697

    Back to the top


    Powered by Savane 3.1-cleanup1