bugGforth - Bugs: bug #27578, make tags throws an exception,...

 
 

bug #27578: make tags throws an exception, comments indicate it should not.

Submitted by:  Charles A. Clinton <cac>
Submitted on:  Thu 01 Oct 2009 10:10:59 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Anton Ertl <anton>
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 03 Oct 2009 06:31:17 PM UTC, comment #1: 

Thanks for the bug report.  I have fixed it (as far as I can tell).
Concerning the THROW, it was just a sanity check.  I have now replaced
this environmental query with a direct test for floored division.

Anton Ertl <anton>
Project AdministratorIn charge of this item.
Thu 01 Oct 2009 10:10:59 PM UTC, original submission:  

VERSION = 0.7.0-20090215

downloaded from cvs in late sept 09.

"make tags" throws an exception:

    make tags
    ./preforth -p ".:~+:." prims2x.fs -e "s\" ./prim.b\" ' output-vi-tag dup process-file bye" >prim.tags-
    cp -p prim.tags- prim.tags
    rm prim.tags-
    ./gforth --die-on-signal -p ".:~+:." -i kernl64l.fi tags.fs except.fs startup.fs -e bye

extend.fs:53: error -13
    [ s" floored" >>>environment?<<< 0= throw ] [if]
make: *** [gforth.tags] Error 1

The "throw" was added to the source code here:

    cvs log -r1.59 extend.fs
    revision 1.59
    date: 2007-03-08 13:55:49 +0000;  author: anton;  state: Exp;  lines: +6 -2;
    M*/ now also works on symmetric-division systems

cvs diff -r1.58 -r1.59 extend.fs
diff -r1.58 -r1.59
53,54c53,58
<     swap >r 0 d+ r> -rot r@ um/mod -rot r> um/mod -rot
<     r> IF IF 1. d+ THEN dnegate ELSE drop THEN ;
---

>     swap >r 0 d+ r> -rot r@ um/mod -rot r> um/mod
>     [ s" floored" environment? 0= throw ] [if]
>         -rot r> IF IF 1. d+ THEN dnegate ELSE drop THEN
>     [else]
>         nip swap r> IF dnegate THEN
>     [then] ;


The comment implies that the code should work; the throw seems to indicate not. Is the throw vestigal?

Charles A. Clinton <cac>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by anton (Posted a comment)
  • -email is unavailable- added by cac (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-10-03 anton Assigned toNone => anton
        Open/ClosedOpen => Closed
        StatusNone => Fixed

    Back to the top


    Powered by Savane 3.5