bugGNU FM - Bugs: bug #26292, Double import of md5 module in...

 
 

bug #26292: Double import of md5 module in lastscrape/import.py

Submitter:  Invalid User ID <#73340>
Submitted:  Wed 22 Apr 2009 02:45:30 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 22 Apr 2009 05:43:51 PM UTC, comment #1: 

Well, I had a problem importing my data to the server. Sending duplicates gave me an error so I added a duplicate check and removal before sending the data to the server.

Here is my updated version: http://pastebin.com/f32d69025

Hope it helps, even if it's not really much.

Invalid User ID <#73340>
Wed 22 Apr 2009 02:45:30 PM UTC, original submission:  

Hi,

the code speaks for itself:

    # The md5 module is deprecated since Python 2.5
    try:
        import hashlib
        md5hash = hashlib.md5
    except ImportError:
        import md5
        md5hash = md5.new
    import md5

to

    # The md5 module is deprecated since Python 2.5
    try:
        import hashlib
        md5hash = hashlib.md5
    except ImportError:
        import md5
        md5hash = md5.new

You don't have to import md5 outside the try/exception. Thanks.
I've included fixed import.py here since I can't access svn depot.

Invalid User ID <#73340>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by #73340 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-22 #73340 Attached File- Added import.py, #17996

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code