bugGnash - The GNU Flash player - Bugs: bug #24355, Nellymoser audio segfaults

 
 

bug #24355: Nellymoser audio segfaults

Submitter:  Benjamin Wolsey <bwy>
Submitted:  Tue 23 Sep 2008 10:23:43 AM UTC
   
 
Category:  None Severity:  6 - Security
Release:  None Status:  Fixed
Privacy:  Public Assigned to:  bwy
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 24 Sep 2008 07:51:10 AM UTC, comment #5: 

Is anyone likely to test this? I've tested with various movies, so I'll close the bug if no one is interested.

Benjamin Wolsey <bwy>
Group Member
Tue 23 Sep 2008 05:59:43 PM UTC, comment #4: 

Done. Tests welcome for all sort of weird audio / video combinations.

Benjamin Wolsey <bwy>
Group Member
Tue 23 Sep 2008 05:25:50 PM UTC, comment #3: 

Looks good to me. Please apply.

Bastiaan Jacques <bjacques>
Group Member
Tue 23 Sep 2008 04:59:42 PM UTC, comment #2: 

Here is a patch that
(a) Leaves the MediaHandler interface exactly as it was.
(b) BUT documents the fact that create{Audio,Video}Decoder throws if the AudioInfo is invalid or any other fatal error occurs (e.g. Ffmpeg can't allocate context: anything that means the decoder is useless).
(c) Modifies all AudioDecoder subclass constructors to take an AudioInfo or SoundInfo by reference (except Nellymoser, which needs a ctor with no arguments for gst).
(d) Documents all AudioDecoder subclass constructors (except gst).
(d) Removes setup() from the AudioDecoder interface, instead throwing on a fatal error in the ctors.
(e) Adds commented out code to use ffmpeg for Nellymoser (because it aborts if enabled).
(f) Modifies all callers of create{Audio,Video}Decoder to catch and log any exception.

It's not as much as it sounds, and is generally straightforward because the interface was so much better and cleaner than for 0.8.3.

It fixes the bug too, by the way.

(file #16555)

Benjamin Wolsey <bwy>
Group Member
Tue 23 Sep 2008 12:33:33 PM UTC, comment #1: 

Not directly related to the bug, but I can confirm that ffmpeg will decode the larger of the two mplayer sample videos, and aborts in AudioDecoderFfmpeg::decodeFrame() on the shorter one. Removing the abort() means the audio is played, but with memory errors (valgrind confirms).

Benjamin Wolsey <bwy>
Group Member
Tue 23 Sep 2008 10:23:43 AM UTC, original submission:  

For samples of FLV with nellymoser audio, see:

http://samples.mplayerhq.hu/A-codecs/Nelly_Moser/

Loading these into Gnash (e.g with file #14418 - easyvideo.swf) causes a segfault.

If ffmpeg supports nellymoser decoding, I suggest dropping Gnash's homespun decoder; if people want nellymoser, they will have to get a recent version of ffmpeg.

The immediate problem is to fix the crash, though.

Benjamin Wolsey <bwy>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #16555:  AudioDecoder.patch added by bwy (27KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bjacques (Posted a comment)
  • -email is unavailable- added by bwy (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-24 bwy Open/ClosedOpen Closed
    2008-09-24 bwy StatusReady For Test Fixed
    2008-09-23 bwy StatusNone Ready For Test
    2008-09-23 bwy Attached File- Added AudioDecoder.patch, #16555

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code