bugGNU Wget - Bugs: bug #23281, Consider using custom facility for...

 
 

bug #23281: Consider using custom facility for password-prompt

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Sat 17 May 2008 08:06:51 PM UTC  
 
Category:  Program Logic Severity:  2 - Minor
Priority:  3 - Low Status:  Needs Discussion
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  None Operating System:  None
Reproducibility:  None Fixed Release:  None
Planned Release:  1.14 Regression:  None
Work Required:  0 - Hours Patch Included:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 14 Aug 2015 02:03:25 PM UTC, comment #6: 

> @Ander Would you like to contact upstream ? (We are not in hurry.)


Yep, I guess I could do that. Ask me for feedback if I haven't reported anything on this for a while.

Ander Juaristi <ajuaristi>
Wed 12 Aug 2015 10:28:43 AM UTC, comment #5: 

Ctrl-C not working annoys me the most - that should be controlled by the calling application.

Looking at the code of getpass.c it seems that Windows code does not suppress ctrl-c !?

@Ander Would you like to contact upstream ? (We are not in hurry.)

Tim Ruehsen <rockdaboot>
Project Administrator
Tue 11 Aug 2015 09:37:22 PM UTC, comment #4: 

> What's wrong with pushing/discussing them upstream?


Absolutely nothing; I think that's entirely appropriate. I don't really have a vested interest in it any longer, though, so it'd probably be better for someone else to get the ball rolling with them.

> I'm looking at the latest getpass sources and they haven't changed much.


That's part of why I was wondering if they might be opposed to the changes, simply on the grounds of behavior stability. But even if that's the case, they probably wouldn't be opposed to a "gnu_getpass2", or perhaps "set_gnupass_opts", to work around such an issue.

Micah Cowan <micahcowan>
Tue 11 Aug 2015 08:18:52 PM UTC, comment #3: 

> If someone decides it's not worth the hassle of maintaining our > own separate solution, I'd be fine with this bug being closed.


The changes you proposed on May 17, 2008 are pretty general. Other projects are likely to benefit from them as well.

What's wrong with pushing/discussing them upstream?

I'm looking at the latest getpass sources and they haven't changed much.

Ander Juaristi <ajuaristi>
Tue 11 Aug 2015 05:58:16 PM UTC, comment #2: 

This bug was opened back when I was a maintainer, which I'm not now, nor am I actually involved in wget development in any way these days, so perhaps this should be reconsidered by current the maintainer.

But yes, improving gnu_getpass would definitely be preferable. I guess I was assuming that gnu_getpass had been around long enough that changing its behavior meaningfully would be undesirable to many (much like wget itself: sometimes "fixing" poor behavior leads to more problems than it solves, when people have gotten used to dependability, and requires a new, alternative interface). But even so, I imagine it'd be preferable to put the new interface into gnulib.

It's conceivable, these seven years later, that most of these improvements have already been made to gnu_getpass or another alternative interface, so that would bear investigation.

In any case, these were admittedly small annoyances, and wget's certainly been doing fine using gnu_getpass in the meantime, which is why the bug is low pri. If someone decides it's not worth the hassle of maintaining our own separate solution, I'd be fine with this bug being closed.

Micah Cowan <micahcowan>
Tue 11 Aug 2015 10:39:20 AM UTC, comment #1: 

Wouldn't it be better to improve gnu_getpass?

Reuben Thomas <rrt>
Sat 17 May 2008 08:06:51 PM UTC, original submission:  

gnu_getpass has some shortcomings.

  • It ignores SIGINT, whereas I'd want it to exit out.
  • It treats EOF and an empty line as the same, whereas I'd wish to treat the former as an exit condition, and the latter as an empty password.
  • When it gets EOF, it doesn't append an extra newline, allowing the prompt to appear immediately after the prompt, rather than on a line on its own. This is difficult to address, because it's difficult to determine where getpass's output went (freshly opened /dev/tty, or stderr?).
Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rockdaboot (Posted a comment)
  • -email is unavailable- added by ajuaristi (Posted a comment)
  • -email is unavailable- added by rrt (Posted a comment)
  • -email is unavailable- added by micahcowan (Submitted the item)
  •  

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-08-21 micahcowan Planned Release1.12 => 1.14
    2008-08-04 micahcowan Priority5 - Normal => 3 - Low

    Back to the top


    Powered by Savane 3.5