bugGnash - The GNU Flash player - Bugs: bug #22386, incompatible pbutils - bogus...

 
 

bug #22386: incompatible pbutils - bogus detection

Submitter:  Sandro Santilli <strk>
Submitted:  Fri 22 Feb 2008 07:34:58 AM UTC
   
 
Category:  build Severity:  4 - Important
Release:  None Status:  Fixed
Privacy:  Public Assigned to:  bjacques
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 22 Feb 2008 04:22:07 PM UTC, comment #4: 

gst_install_plugins_supported tells you whether or not _sync and _async are likely to fail. So if you don't call gst_install_plugins_supported, you won't be sure if it will fail or not until it has been run (this is what asac meant by runtime failure).

Anyway, I just avoided the call to gst_install_plugins_supported if it's not available.

Bastiaan Jacques <bjacques>
Group Member
Fri 22 Feb 2008 10:06:43 AM UTC, comment #3: 

Summary of IRC discussion with asac:

_async is available in gutsy. Would likely give a runtime error
in gutsy, but is there, contrary to _supported.

handlin the error at runtime could let you go in _sync mode, right ?

Sandro Santilli <strk>
Group Member
Fri 22 Feb 2008 09:23:44 AM UTC, comment #2: 

The original patch by asac didn't use the gst_install_plugins_supported symbol at all:

http://cvs.savannah.gnu.org/viewvc/gnash/server/asobj/NetStreamGst.cpp?root=gnash&r1=1.54&r2=1.55

Sandro Santilli <strk>
Group Member
Fri 22 Feb 2008 08:47:57 AM UTC, comment #1: 

I committed a change in configure.ac so it checks
for gst_install_plugins_supported.
I'd still like to know if it's possible to make the
code work for older gstreamer...

Sandro Santilli <strk>
Group Member
Fri 22 Feb 2008 07:34:58 AM UTC, original submission:  

with current head:

./configure ...
 checking for modern pbutils... ok

make
 server/asobj/NetStreamGst.cpp:617: error: 'gst_install_plugins_supported' was not declared in this scope

I've seen configure.ac checks for 'gst_install_plugins_sync'
in the gst/pbutils/install-plugins.h header to tell.

My install-plugins.h file has 'gst_install_plugins_sync'
but doesn't have 'gst_install_plugins_supported'.

The header comes from this package on Ubuntu Gutsy:
  libgstreamer-plugins-base0.10-dev 0.10.14-1ubuntu3

So, is it possible to make our code compatible to that or
should we just fix the detection code to look for
'gst_install_plugins_supported' instead of
'gst_install_plugins_sync' ?

I'm for option 1 of course..

NOTE: this would be a blocker, but it's not in the 0.8.2 branch
yes so I only tagged as important.

Sandro Santilli <strk>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bjacques (Posted a comment)
  • -email is unavailable- added by strk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-02-22 bjacques StatusReady For Test Fixed
        Assigned toNone bjacques
        Open/ClosedOpen Closed
    2008-02-22 strk StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code