bugfindutils - Bugs: bug #19550, bloat in 4.2.30, gnulib regex is...

 
 

bug #19550: bloat in 4.2.30, gnulib regex is always used

Submitted by:  Andreas Metzler <ametzler>
Submitted on:  Sun 08 Apr 2007 12:34:29 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  Compilation Failure Status:  Wont Fix
Privacy:  Public Assigned to:  James Youngman <jay>
Originator Name:  Open/Closed:  Closed
Release:  4.2.30 Fixed Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 28 Apr 2007 07:34:37 AM UTC, comment #3: 

Thanks for enlightening me.
cu andreas

Andreas Metzler <ametzler>
Sun 22 Apr 2007 04:38:56 PM UTC, comment #2: 

If I build on Debian, I see that the cofnigure script decides to replace the system regex implementation with the gnulib one, because it sees that this test fails:

|           /* This test is from glibc bug 3957, reported by Andrew Mackey.  */
|           re_set_syntax (RE_SYNTAX_EGREP | RE_HAT_LISTS_NOT_NEWLINE);
|           memset (&regex, 0, sizeof regex);
|           s = re_compile_pattern ("a[^x]b", 6, &regex);
|           if (s)
|             return 4;
|
|           /* This should fail, but succeeds for glibc-2.5.  */
|           if (re_search (&regex, "a\nb", 3, 0, 3, &regs) != -1)
|             return 5;

So it seems that gnulib has fixed a bug which is not yet fixed in my system's glibc.  That explains why find includes glibc's regex implementation on my system.  Perhaps the explanation is the same for yours.   It is a recent bug.

The bugzilla entry for the bug is visible at:
http://sourceware.org/bugzilla/show_bug.cgi?id=3957

I'm marking the bug as "won't fix" because (supposing the explanation is the same for you) this is the right thing to do.  That is, the bug-fix should be included.

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 08 Apr 2007 01:46:15 PM UTC, comment #1: 

gl_INCLUDED_REGEX is not part of current gnulib anymore,

 2005-08-23  Paul Eggert  <eggert@cs.ucla.edu>

        * m4/regex.m4 (gl_INCLUDED_REGEX): Remove; no longer used.
        All contents moved to gl_REGEX.
        (gl_REGEX): Don't bother checking whether lib/regex.c exists;
        assume that it does.

therefore building findutils 4.2.30 against the newer gnulib is not possible.

Andreas Metzler <ametzler>
Sun 08 Apr 2007 12:34:29 PM UTC, original submission:  

-rwxr-xr-x 1 ametzler ametzler  97518 Apr  8 12:09 4.2.29/usr/local/bin/find
-rwxr-xr-x 1 ametzler ametzler 155092 Apr  8 12:10 4.2.30/usr/local/bin/find

4.2.30 is more than 50% bigger than 4.2.29. I guess this is coused by this change to configure.in:

----------------------
 dnl Use gl_INCLUDED_REGEX so that findutils will build on systems like
 dnl Solaris, which lacks those functions in libc (see GNU Savannah bug
-dnl #11710)
-dnl gl_INCLUDED_REGEX([gnulib/lib/regex.c])
-gl_REGEX()
+dnl #11710, bug# 17861)
+gl_INCLUDED_REGEX([gnulib/lib/regex.c])
+dnl gl_REGEX()
-----------------------

since the only real difference in buildlogs is that regex.c from gnulib is used although I have a perfectly working regex support in libc.
-----------------------------
 gcc -DHAVE_CONFIG_H -I. -I. -I../..     -Wall -O2 -c yesno.c
+gcc -DHAVE_CONFIG_H -I. -I. -I../..     -Wall -O2 -c regex.c
 rm -f libgnulib.a
-ar cru libgnulib.a argmatch.o cycle-check.o basename.o stripslash.o xalloc-die.o xgetcwd.o xreadlink.o xstrtoumax.o strftime.o canonicalize.o closeout.o dirname.o exitfail.o filemode.o filenamecat.o human.o idcache.o modechange.o mountlist.o quote.o quotearg.o savedir.o fopen-safer.o dup-safer.o fd-safer.o xmalloc.o xstrtol.o xstrtoul.o yesno.o
+ar cru libgnulib.a argmatch.o cycle-check.o basename.o stripslash.o xalloc-die.o xgetcwd.o xreadlink.o xstrtoumax.o strftime.o canonicalize.o closeout.o dirname.o exitfail.o filemode.o filenamecat.o human.o idcache.o modechange.o mountlist.o quote.o quotearg.o savedir.o fopen-safer.o dup-safer.o fd-safer.o xmalloc.o xstrtol.o xstrtoul.o yesno.o regex.o
 ranlib libgnulib.a
------------------------------

4.3.1 does not contain the respective change to configure.in and is unaffected. Perhaps updating regex.m4 might help.

cu andreas

Andreas Metzler <ametzler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-28 jay Open/ClosedOpen => Closed
    2007-04-28 ametzler Carbon-CopyRemoved 20807 => -
    2007-04-22 jay StatusNone => Wont Fix
        Assigned toNone => jay
    2007-04-08 ametzler Carbon-CopyRemoved 20807 => -
    2007-04-08 ametzler Carbon-CopyRemoved 20807 => -

    Back to the top


    Powered by Savane 3.5