Gnash - The GNU Flash player - Tasks: task #5837, Remove rendering calls from parser
You are not allowed to post comments on this tracker with your current authentication level.
task #5837: Remove rendering calls from parser
Submitter: | Sandro Santilli <strk> | ||
Submitted: | Tue 22 Aug 2006 08:13:14 PM UTC | ||
Should Start On: | Mon 21 Aug 2006 10:00:00 PM UTC | Should be Finished on: | Tue 12 Sep 2006 10:00:00 PM UTC |
Category: | None | Priority: | 7 - High |
Status: | Cancelled | Privacy: | Public |
Assigned to: | nihilus | Percent Complete: | 100% |
Open/Closed: | Closed | Effort: | 0.00 |
Jump to the original submission
Fri 15 Oct 2010 09:11:18 AM UTC, comment #20: |
Benjamin Wolsey <bwy> |
Thu 18 Sep 2008 07:25:44 AM UTC, comment #19: Oops, sorry, wrong bug :/ |
Sandro Santilli <strk> |
Thu 18 Sep 2008 07:24:31 AM UTC, comment #18:
|
Sandro Santilli <strk> |
Mon 25 Sep 2006 03:24:28 PM UTC, comment #17: I split the bitmap_character class into _def and _instance.
|
Sandro Santilli <strk> |
Mon 25 Sep 2006 01:50:48 PM UTC, comment #16: It seems that part of the problem is the bitmap_character class.
|
Sandro Santilli <strk> |
Mon 25 Sep 2006 01:42:23 PM UTC, comment #15: Not specifically, although the same problem occurs with caching. |
Bastiaan Jacques <bjacques> |
Mon 25 Sep 2006 01:26:51 PM UTC, comment #14: Are we talking about the cache here ?
|
Sandro Santilli <strk> |
Mon 25 Sep 2006 01:17:16 PM UTC, comment #13: I suspect it's possible to delay creating the bitmap_info structures until it's time to actually render the corresponding objects. |
Bastiaan Jacques <bjacques> |
Mon 25 Sep 2006 01:08:31 PM UTC, comment #12: Would it be possible to decouple bitmap_info objects from any renderer (make it indipendent from renrerer?) |
Sandro Santilli <strk> |
Mon 25 Sep 2006 12:05:17 PM UTC, comment #11: Removing rid of create_bitmap_info_xyz() calls is a prerequisite for Cairo rendering to work at all. The main problem is that read_all_swf() and friends are called before a renderer is created. This means that the renderer will later be fed bogus bitmap_info structures. This in turn crashes the Cairo renderer, and I think it'll produce invalid output for other renderers. |
Bastiaan Jacques <bjacques> |
Sat 26 Aug 2006 10:26:09 PM UTC, comment #10: Yes, probably. See also stuff in tag_loaders (grep for render::).
|
Sandro Santilli <strk> |
Sat 26 Aug 2006 09:23:34 PM UTC, comment #9: I suppose you mean create_bitmap_INFO_rgb{a}... |
Markus Gothe <nihilus> |
Sat 26 Aug 2006 11:48:18 AM UTC, comment #8: Yeah, I can do that... I just didn't wanted to change to much of the code... But it will definitly speed up loading time, which is a good thing. |
Markus Gothe <nihilus> |
Sat 26 Aug 2006 08:51:21 AM UTC, comment #7: I confirm I can't reproduce "shock absorber adv." (jumping boobs)
|
Sandro Santilli <strk> |
Sat 26 Aug 2006 08:40:30 AM UTC, comment #6: I got reports about your changes fixing some existing problems.
|
Sandro Santilli <strk> |
Thu 24 Aug 2006 09:34:39 PM UTC, comment #5: Indeed, I backtracked the process. Seem like glEnable() is one of the culprits here... |
Markus Gothe <nihilus> |
Thu 24 Aug 2006 12:03:22 AM UTC, comment #4: I don't believe NPTL would make any difference. The problem is that if more than one thread access the OpenGL or X11 display seperately, they can conflict. This conflict is timing based, so it works on some systems and not on other. The trick is to properly get the X11 and OpenGL contexts, and then swap them. In this case the parsing thread shouldn't access the graphics context anyway. The original pluging actually worked this way.
|
Rob Savoye <rsavoye> |
Wed 23 Aug 2006 09:03:58 PM UTC, comment #3: I don't know what NPTL is, anyway I can't reproduce any segfault
|
Sandro Santilli <strk> |
Wed 23 Aug 2006 07:07:26 PM UTC, comment #2: I think this might only affect systems based on only NPTL based systems... Can anyone running Linux Threads and glibc < 2.4 confirm by testing and then switching to NPTL and try it? |
Markus Gothe <nihilus> |
Tue 22 Aug 2006 08:24:23 PM UTC, comment #1: To verify a problem is related to this "bug" you can try building
|
Sandro Santilli <strk> |
Tue 22 Aug 2006 08:13:14 PM UTC, original submission:
Some parsing methods (read funx of some definition classes) currently call rendering API, which (at least for OpenGL) seems to have problems working fine with threads.
|
Sandro Santilli <strk> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 18 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-10-15 | bwy | Status | In Progress | Cancelled | |
Open/Closed | Open | Closed | |||
2006-09-25 | strk | Status | Ready For Test | In Progress | |
2006-09-06 | nihilus | Should be Finished on | 2006-09-06 | 2006-09-12 | |
2006-08-26 | strk | Status | Done | Ready For Test | |
Open/Closed | Closed | Open | |||
2006-08-24 | nihilus | Percent Complete | 70% | 100% | |
Open/Closed | Open | Closed | |||
2006-08-24 | nihilus | Percent Complete | 100% | 70% | |
Open/Closed | Closed | Open | |||
2006-08-24 | nihilus | Status | In Progress | Done | |
Percent Complete | 30% | 100% | |||
Open/Closed | Open | Closed | |||
2006-08-24 | nihilus | Percent Complete | 0% | 30% | |
2006-08-24 | nihilus | Should be Finished on | 2006-08-21 | 2006-09-06 | |
Status | None | In Progress | |||
2006-08-23 | nihilus | Assigned to | None | nihilus | |
2006-08-22 | nihilus | Carbon-Copy | - | Added nihilus |
Powered by Savane 3.13-3230.
Corresponding source code
The renderer is still used during parsing for storing cached bitmaps, but this is a reasonable design decision.