taskSavannah Administration - Tasks: task #14536, Submission of LibreRead

 
 

task #14536: Submission of LibreRead

Submitter:  Nirmal Almara <mysticmode>
Submitted:  Mon 12 Jun 2017 12:16:48 PM UTC
   
 
Should Start On:  Mon 12 Jun 2017 12:00:00 AM UTC Should be Finished on:  Thu 22 Jun 2017 12:00:00 AM UTC
Category:  Project Approval Priority:  * 5 - Normal
Status:  Done Privacy:  Public
Assigned to:  ineiev Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 22 Jun 2017 12:33:19 PM UTC, comment #27: 

Thanks for accepting my package!

I'm using Git as a version control system for LibreRead. But in the source control I see ViewVC which is for CVS and Subversion. 
http://cvs.savannah.nongnu.org/viewvc/libreread/

Is there a way to change the repository to git version control?

Nirmal Almara <mysticmode>
Thu 22 Jun 2017 11:35:29 AM UTC, comment #26: 

Thank you, approving.

>Those are PDFjs files, and I've put the COPYRIGHT AND LICENSE inside the respective directories. Is it necessary that I should mention all the filenames too in the COPYRIGHT?


Yes, it would be nice to have them listed there, and an explicit notice that the conditions from the LICENSE apply to them.

Ineiev <ineiev>
Site Administrator
Thu 22 Jun 2017 09:35:49 AM UTC, comment #25: 

Thank you! I got it.

Could you check these places, whether I'm right.
https://github.com/mysticmode/LibreRead/blob/master/static/css/images/COPYRIGHT

https://github.com/mysticmode/LibreRead/blob/master/static/js/pdfjs/COPYRIGHT

Those are PDFjs files, and I've put the COPYRIGHT AND LICENSE inside the respective directories. Is it necessary that I should mention all the filenames too in the COPYRIGHT?

Nirmal Almara <mysticmode>
Thu 22 Jun 2017 09:15:40 AM UTC, comment #24: 

I agree, I could do better.

LICENSE is the text of the license; copyright notices are copyright notices, they claim who the copyright holders of the respective files are; and license notices say that the files are under the license in question. The text of the license doesn't list the copyright holders of the files, and it doesn't say what files it apply to. Those are different texts.

Ineiev <ineiev>
Site Administrator
Tue 20 Jun 2017 08:37:37 AM UTC, comment #23: 

This is going too laggy. I wish the administrator could be faster in processing this. I think this is one of the reasons, Free software is lagging behind.

Nirmal Almara <mysticmode>
Tue 20 Jun 2017 07:43:35 AM UTC, comment #22: 

What do you mean, add copyright notices for PDF.js?. I've explicity put the complete LICENSE text as a file inside the directory /static/js/pdfjs

Could you be more elaborate on that one?

For cc0 public domain license, i've mentioned it as a seperate file here
https://github.com/mysticmode/LibreRead/blob/master/static/img/collections_banner_LICENSE

Nirmal Almara <mysticmode>
Tue 20 Jun 2017 05:52:34 AM UTC, comment #21: 

Please add copyright notices for those files coming from PDF.js; since *.map files are generated, you may consider removing them instead.

If some file is public domain, you should mention it explicitly.

Ineiev <ineiev>
Site Administrator
Tue 20 Jun 2017 01:23:13 AM UTC, comment #20: 

Hi, any update on the approval progress for LibreRead?

Nirmal Almara <mysticmode>
Sun 18 Jun 2017 01:06:27 PM UTC, comment #19: 

I have put Apache 2.0 LICENSE complete text as a file inside

/static/css/images/LICENSE
/static/js/pdfjs/LICENSE

Please let me know if that is fine. Thanks!

P.S. Sorry for the previous comment. There is no info about Rich Markup.

Nirmal Almara <mysticmode>
Sun 18 Jun 2017 01:05:23 PM UTC, comment #18: 

I have put Apache 2.0 LICENSE complete text as a file inside

<a href="https://github.com/mysticmode/LibreRead/blob/master/static/css/images/LICENSE
" target="blank">/static/css/images/LICENSE</a>

<a href="https://github.com/mysticmode/LibreRead/blob/master/static/js/pdfjs/LICENSE" target="blank">/static/js/pdfjs/LICENSE</a>


Please let me know if that is fine. Thanks!

Nirmal Almara <mysticmode>
Sun 18 Jun 2017 06:51:35 AM UTC, comment #17: 

I've included filenames in static/css/img/COPYRIGHT for all images except this one https://github.com/mysticmode/LibreRead/blob/master/static/img/collections_banner.jpg

That image is taken from
https://pixabay.com/en/books-library-read-shelves-silence-1617327/ and it has CC0 Public Domain license.

Nirmal Almara <mysticmode>
Sun 18 Jun 2017 06:42:42 AM UTC, comment #16: 

Also static/js/pdfjs/build/*.map are executable files. How can I add copyright notices to those files?

Or, Should I add Apache 2.0 in the root directory of the project mentioning those files?

Nirmal Almara <mysticmode>
Sun 18 Jun 2017 06:39:13 AM UTC, comment #15: 

Sure, But I'm little confused about static/css/images/* and static/js/pdfjs/build/* .map

Those files come from PDF.js library. Should I put Apache 2.0 license for those files?

Nirmal Almara <mysticmode>
Sun 18 Jun 2017 06:24:29 AM UTC, comment #14: 

Thank you!

Could you write something more explicit in COPYRIGHT files relating
to the images? Ideally, it should list particular files, and say
it applies to them.

Also, some files refer to Apache 2.0 license without providing its
full text; it would be nice if the text of that license could be easily
found in the distribution tarball of your package.

Those are minor issues, and I'd probably approve your package,
but images in static/css/images still have no copyright and license notices,
as well as static/js/pdfjs/build/*.map, and some other files.

Ineiev <ineiev>
Site Administrator
Sat 17 Jun 2017 02:44:40 PM UTC, comment #13: 

I've added copyright and license text on all files. For images, I placed COPYRIGHT and LICENSE files in the image directory itself.

Please have a look and let me know for any changes. Thanks!

Nirmal Almara <mysticmode>
Sat 17 Jun 2017 02:11:03 PM UTC, comment #12: 

Thank you; let us proceed with LibreRead itself.

All non-trivial files should have valid license and copyright notices; this applies to the source files, READMEs and images.  Many files in LibreRead lack them; could you fix that?

Ineiev <ineiev>
Site Administrator
Sat 17 Jun 2017 12:48:14 PM UTC, comment #11: 

As far as I know, the FSF does not generally consider connecting to a service over the network to be the equivalent of linking, or a plugin. The two licenses need not be compatible.

From your description, I'm not convinced that Elasticsearch is nonfree. It would depend on exactly how all the pieces interact; and that analysis seems unnecessary for us. We're not being asked to host Elasticsearch. IMHO ... -k

Karl Berry <karl>
Site Administrator
Sat 17 Jun 2017 10:59:36 AM UTC, comment #10: 

Thank you for clarifications!

> There is no Elasticsearch code I'm including in my project.


Generally, you don't need to include any code to
form a combined executable
you said you basically link to it, and it's sufficient.

The license of Elasticsearch may or may not impose conditions
on programs that use it; but it's a dependency, and it must
be free in order to host a project that depends on it on Savannah.
When I download Elasticsearch sources from GitHub,
I see in core/licenses/lucene-NOTICE.txt:


JUnit (junit-4.10) is licensed under
the Common Public License v. 1.0
See http://junit.sourceforge.net/cpl-v10.html


The CPL is GPL-incompatible.


The KStem stemmer in
analysis/common/src/org/apache/lucene/analysis/en
was developed by Bob Krovetz and Sergio Guzman-Lara
(CIIR-UMass Amherst) under the BSD-license.


The Original BSD License is GPL-incompatible.

core/licenses/spatial4j-NOTICE.txt refers to the
Eclipse Public License,
which is GPL-incompatible.

At last, core/licenses/jts-LICENSE.txt is the text of the LGPLv3.
In other words, the authors of Elasticsearch used some code without
permission.  This technically means that the users aren't allowed to copy,
modify and redistribute Elasticsearch.

Ineiev <ineiev>
Site Administrator
Fri 16 Jun 2017 02:03:57 PM UTC, comment #9: 

There is no Elasticsearch code I'm including in my project. It runs as a separate service as Jacob mentioned.

And this is how LibreRead connects with Elasticsearch
https://github.com/mysticmode/LibreRead/blob/master/server.go#L153

Nirmal Almara <mysticmode>
Fri 16 Jun 2017 01:59:13 PM UTC, comment #8: 

I am a little confused why the license of Elasticsearch is relevant here. From my understanding, Elasticsearch runs as a separate service on the machine and then the LibreRead software merely calls it. No Elasticsearch code is in LibreRead or compiled into LibreRead, as far as I am aware.

Jacob Weisz <ocdtrekkie>
Fri 16 Jun 2017 01:16:33 PM UTC, comment #7: 

"The LGPLv2.1 may be upgraded to any version of the GPL since 2,
but the LGPLv3 is not compatible with future versions of the GPL."

Do you think, it violates for me to use GPLv3 license in my software?

Nirmal Almara <mysticmode>
Fri 16 Jun 2017 12:30:47 PM UTC, comment #6: 

I checked the Apache 2.0 license compatibility from this page https://www.apache.org/licenses/GPL-compatibility.html

It clearly states that it is compatible with GPLv3. If not, that's bad I'm going to continue using Github.

Thanks!

Nirmal Almara <mysticmode>
Fri 16 Jun 2017 11:28:17 AM UTC, comment #5: 

PDF.js: I think you are right, Node.js is not a dependency, so it's compatible.

Elasticsearch is not completely Apache 2.0. Its licenses are listed in
NOTICE.txt, they include the LGPLv3 (supplied in a way that in fact
violates that license), and a number of licenses for netty, some of
them are ambiguously mentioned (like "BSD Style License"), but not
provided in the text of the notice.

Let us take for granted that they are GPLv3+-compatible. However,
in the text of the source files, no GNU licenses are ever mentioned,
so the user has to assume that only the exact versions of the licenses
apply. The LGPLv2.1 may be upgraded to any version of the GPL since 2,
but the LGPLv3 is not compatible with future versions of the GPL.

Ineiev <ineiev>
Site Administrator
Thu 15 Jun 2017 04:59:29 PM UTC, comment #4: 

Regarding Elasticsearch:

I'm using Elasticsearch as a service which runs on localhost:9200 and it has a REST API.

Basically I'm linking it to my project. And Elasticsearch is Apache 2.0 licensed. Isn't it compatible with my GPLv3?

Nirmal Almara <mysticmode>
Thu 15 Jun 2017 02:10:25 PM UTC, comment #3: 

Thanks for reply!

I'm not sure about Elasticsearch. I'll look into it.

But for PDF.js, I'm not using it with Node.js. I'm directly including the files in my project.

Could you check here ?https://github.com/mysticmode/LibreRead/blob/master/templates/viewer.html

Also when you see in /static/js/ I've included PDF.js javascript files. So I think using PDF.js as Apache 2 lincense is compatible with GPL v3?

If not I'll try using libraries which has licensing that is compatible to GPL.

I'll reply about Elasticsearch soon.

Nirmal Almara <mysticmode>
Thu 15 Jun 2017 02:09:30 PM UTC, comment #2: 

Thanks for reply!

I'm not sure about Elasticsearch. I'll look into it.

But for PDF.js, I'm not using it with Node.js. I'm directly including the files in my project.

Could you check here ?https://github.com/mysticmode/LibreRead/blob/master/templates/viewer.html

Also when you see in /static/js/ I've included PDF.js javascript files. So I think using PDF.js as Apache 2 lincense is compatible with GPL v3?

If not I'll try using libraries which has licensing that is compatible to GPL.

I'll reply about Elasticsearch soon.

Nirmal Almara <mysticmode>
Thu 15 Jun 2017 01:59:07 PM UTC, comment #1: 

Thank you for submitting your package!

When I download PDF.js I see "install Node.js" in README, this suggests PDF.js uses that library; in its turn, some parts of Node.js are released under the OpenSSL license, and it is GPL-incompatible.  So it looks like your package isn't going to be GPL-compatible: you can allow linking your code with Node.js, but your users shan't be able to combine your package with third-party GPLed software.

(I couldn't find licenses for some parts of Elasticsearch, so I can't tell if similar issues apply to that dependency.)

Ineiev <ineiev>
Site Administrator
Mon 12 Jun 2017 12:16:48 PM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves or discards the registration.


Registration Administration


While this item will be useful to track the registration process, approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators, effectively logged as site administrators (superuser):



Registration Details


  • Name: LibreRead
  • System Name:  libreread
  • Type: non-GNU software and documentation
  • License: GNU General Public License v2 or later (My dependencies which are Elasticsearch5 and PDF.js, both have Apache 2.0 licensing.)





Description:

LibreRead is a self-hosted Free(Libre) ebook reader. Privacy is the primary focus. Simple setup script. Browser based, responsive design.
Full-text search through all the ebooks and find the relevant content. Highlight your favorite content. Add annotations to your favorite content. Group books into collections. Currently supports PDF files. EPUB support coming soon.

It's written in Go and the dependencies are Elasticsearch 5 and PDF.js.

I want this project to be moved to Savannah. I think that's the right way as I'm building a Libre software.




Other Software Required:

As mentioned above, these are the dependecies:
Elasticsearch 5 + Apache 2.0 + https://www.elastic.co
PDF.js + Apache 2.0 + https://mozilla.github.io/pdf.js/


Other Comments:

There is no more to say. I would like this project to be hosted in Savannah. I want to continue building Libre softwares. Thanks!


Tarball URL:

https://github.com/mysticmode/LibreRead


Nirmal Almara <mysticmode>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mysticmode (Posted a comment)
  • -email is unavailable- added by mysticmode
  • -email is unavailable- added by karl (Posted a comment)
  • -email is unavailable- added by ocdtrekkie (Posted a comment)
  • -email is unavailable- added by ineiev (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-22 ineiev StatusIn Progress Done
        Open/ClosedOpen Closed
    2017-06-20 mysticmode Carbon-Copy- Added mysticmode
    2017-06-20 mysticmode Carbon-CopyRemoved -email is unavailable- -
    2017-06-20 mysticmode Carbon-Copy- Added -email is unavailable-
    2017-06-20 mysticmode Carbon-CopyRemoved 109483 -
    2017-06-15 ineiev StatusNone In Progress
        Assigned toNone ineiev

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code