mainThe GNU Bourne-Again SHell - Support: sr #110634, Missing HAVE_SELECT prevents...


sr #110634: Missing HAVE_SELECT prevents libreadline from compiling on platforms without pselect()

Submitter:  None
Submitted:  Thu 07 Apr 2022 06:41:15 AM UTC
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Open
Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup

Thu 07 Apr 2022 06:41:15 AM UTC, original submission:  

Confirmed on master, this define allows input.c to compile

diff --git a/lib/readline/input.c b/lib/readline/input.c
index 44d14872..bf3424c1 100644
--- a/lib/readline/input.c
+++ b/lib/readline/input.c
@@ -79,7 +79,7 @@ extern int errno;
 #  define O_NDELAY O_NONBLOCK  /* Posix style */
-#if defined (HAVE_PSELECT)
+#if defined (HAVE_PSELECT) || defined (HAVE_SELECT)
 extern sigset_t _rl_orig_sigset;
@@ -805,7 +805,7 @@ rl_getc (FILE *stream)
   int result;
   unsigned char c;
   int fd;
-#if defined (HAVE_PSELECT)
+#if defined (HAVE_PSELECT) || defined(HAVE_SELECT)
   sigset_t empty_set;
   fd_set readfds;

This was reported to the mailing list from what I can tell, but the code has changed so this issue reappeared.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by chet (Updated the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-08 chet StatusNone Done

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code