mainAutoconf - Support: sr #110561, autoconf: store autom4te request...

 
 

sr #110561: autoconf: store autom4te request keys in sorted order

Submitter:  Sergei Trofimovich <slyfox>
Submitted:  Sun 07 Nov 2021 04:02:37 PM UTC
   
 
Priority:  * 7 - Release N (Desirable) Severity:  3 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 11 Dec 2023 05:06:30 PM UTC, comment #2: 

Your patch was actually committed over a year ago, <https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=c2ab755698db245898a4cc89149eb5df256e4bd0>.  It's good that this bug was left open, though, because it did need adjustment to work with very old perl, and I'm not sure I would have thought to test with very old perl if I hadn't been looking at this bug.

The adjustment has now also been landed: <https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=185d1db28b48f78eb480a8d19db100ecda7a4fc1>.

Zack Weinberg <zackw>
Group administrator
Fri 08 Dec 2023 06:48:16 PM UTC, comment #1: 

We will need to tweak the patch so that it falls back to the old behavior when we have an old Data::Dumper module that doesn't have the Sortkeys method, but that should not be difficult.

Zack Weinberg <zackw>
Group administrator
Sun 07 Nov 2021 04:02:37 PM UTC, original submission:  

Noticed unstable key order when debugging unrelated bug.
Data::Dumper's SortKeys() makes ordering stable and decreases
diffs from run to run. No functional change otherwise.

The patch is attached.

The patch initially posted at https://lists.gnu.org/archive/html/autoconf-patches/2021-08/msg00000.html

Sergei Trofimovich <slyfox>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zackw (Posted a comment)
  • -email is unavailable- added by slyfox (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-11 zackw StatusConfirmed Done
        Open/ClosedOpen Closed
    2023-12-08 zackw StatusNone Confirmed
    2023-12-08 zackw Priority5 - Unprioritized 7 - Release N (Desirable)
    2021-11-07 slyfox Attached File- Added 0001-autoconf-store-autom4te-request-keys-in-sorted-order.patch, #52214

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code