mainAutoconf - Support: sr #110352, "Specific warnings options...

 
 

sr #110352: "Specific warnings options for autoreconf" test can fail due to buggy third party macros

Submitter:  Zack Weinberg <zackw>
Submitted:  Sat 31 Oct 2020 02:30:52 PM UTC
   
 
Priority:  * 5 - Unprioritized Severity:  2 - Minor
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 02 Nov 2020 10:24:26 PM UTC, comment #1: 

Fixed by 45f1c8ba95c84a2980aa2ed3d03f1674fcc114fa.

Zack Weinberg <zackw>
Group administrator
Sat 31 Oct 2020 02:30:52 PM UTC, original submission:  

If there are third-party .m4 files visible to aclocal, that trigger warnings or errors, the "Specific warnings options for autoreconf" test (torture.at:1865) will fail when autoreconf runs aclocal.  For instance:


275. torture.at:1865: testing Specific warnings options for autoreconf ...
./torture.at:1873: automake --version || exit 77
stderr:
stdout:
automake (GNU automake) 1.16.1
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <https://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>
       and Alexandre Duret-Lutz <adl@gnu.org>.
./torture.at:1897: autoreconf -Werror -Wall
0a1,5
> aclocal: warnings are treated as errors
> /opt/csw/share/aclocal/gtk.m4:7: warning: underquoted definition of AM_PATH_GTK
> /opt/csw/share/aclocal/gtk.m4:7:   run info Automake 'Extending aclocal'
> /opt/csw/share/aclocal/gtk.m4:7:   or see https://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal
> autoreconf: error: aclocal failed with exit status: 1
./torture.at:1897: exit code was 1, expected 0
275. torture.at:1865: 275. Specific warnings options for autoreconf (torture.at:1865): FAILED (torture.at:1897)


We should make the test suite run aclocal in a way that prevents it from reading third-party .m4 files.

(Originally reported by Dagobert as part of sr #110320, logs extracted from file #49872.)

Zack Weinberg <zackw>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zackw (Submitted the item)
  • -email is unavailable- added by zackw
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-02 zackw StatusConfirmed Done
        Open/ClosedOpen Closed
    2020-10-31 zackw Carbon-Copy- Added dagobert

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code