helpAutoconf - Support: sr #110325, autoupdate introduces a second...

 
 

sr #110325: autoupdate introduces a second invocation of AC_OUTPUT

Submitted by:  Bruno Haible <haible>
Submitted on:  Sun 04 Oct 2020 10:57:35 PM UTC  
 
Category:  None Priority:  1 - Later
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Operating System:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 30 Oct 2020 08:52:21 PM UTC, comment #1: 

Regrettably, I do not think it will be possible to make any improvements to autoupdate for 2.70.  The algorithm it uses is already extremely brittle and I'm buried in regressions in automake itself.

(What's going on here is, autoupdate runs M4 with an unusual set of macro definitions active: `AC_OUTPUT` is recognized as a macro, but `dnl` isn't.  It's just another word.  It might not be possible to improve the handling of this case without a new feature in M4 itself -- allowing more than one comment starter to be active at once.)

Zack Weinberg <zackw>
Project Administrator
Sun 04 Oct 2020 10:57:35 PM UTC, original submission:  

In the attached example configure.ac, there is a line

dnl AC_OUTPUT([Makefile])

and autoupdate 2.69c transforms it to

dnl AC_CONFIG_FILES([Makefile])
AC_OUTPUT

Since there is already an AC_OUTPUT invocation in the configure.ac file, now there are two AC_OUTPUT invocations!

IMO, either autoupdate should leave comment lines untouched, or should add a 'dnl ' prefix to all continuation lines of the expansion.

Bruno Haible <haible>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49922:  configure.ac added by haible (32KiB - application/octet-stream)
file #49923:  configure.ac.diff added by haible (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zackw (Posted a comment)
  • -email is unavailable- added by haible (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-10-30 zackw Priority5 - Normal => 1 - Later
    2020-10-04 haible Attached File- => Added configure.ac, #49922
        Attached File- => Added configure.ac.diff, #49923

    Back to the top


    Powered by Savane 3.6