mainAutoconf - Support: sr #110273, New test suite failures of 2.69b...

 
 

sr #110273: New test suite failures of 2.69b on OpenBSD 6.5

Submitter:  Bruno Haible <haible>
Submitted:  Fri 17 Jul 2020 09:00:47 PM UTC
   
 
Priority:  * 5 - Unprioritized Severity:  3 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Operating System:  *BSD
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 21 Jul 2020 12:53:31 PM UTC, comment #8: 

Thanks. I confirm that with these patches, and when I set the environment variable MAKE=gmake, all tests pass.

You can close this ticket.

Bruno Haible <haible>
Tue 21 Jul 2020 12:53:40 AM UTC, comment #7: 


> How about writing ${MAKE-make} instead?


Thanks, that makes sense. I looked for other examples of the problem and installed patches to fix them:

Prefer ‘$(MAKE)’ to ‘make’ in Makefiles

Don’t assume plain ‘make’ in C unit tests

Please give them a try.

Paul Eggert <eggert>
Group administrator
Mon 20 Jul 2020 09:04:24 PM UTC, comment #6: 


> There's no 'gmake' on my OpenBSD 6.7 platform


It's part of the add-on packages. Here's my recipe to fetch it and a couple of other programs:

# Install some packages.
# List is at https://ftp.hostserver.de/pub/OpenBSD/6.7/packages/amd64/
# See https://www.openbsd.org/faq/faq15.html#PkgMgmt
Edit ~/.profile to define PKG_PATH:
PKG_PATH=https://ftp.hostserver.de/pub/OpenBSD/6.7/packages/`uname -m`/
export PKG_PATH
Logout.

# pkg_add bzip2
# pkg_add gtar
# pkg_add bash
# pkg_add gmake
# pkg_add vim, pick no_x11 variant
# pkg_add emacs, pick no_x11 variant


> GNU Make sets MAKEFLAGS=w in the environment, and presumably this confuses OpenBSD Make.


Indeed: The GNU make behaviour is explained in the thread starting at https://lists.gnu.org/archive/html/help-make/2016-03/msg00009.html . Whereas the OpenBSD make's interpretation of MAKEFLAGS is documented in https://man.openbsd.org/make .

So, really, inside of GNU make invocations on OpenBSD, one should avoid invoking 'make'.

> One possibility is that you need to be consistent about which 'make' you're using, e.g., './configure MAKE=gmake'.


No, this does not help because tests/autotest.at lines 1938 and 1999 invokes precisely 'make', even it the environment variable MAKE is set. How about writing ${MAKE-make} instead?

Bruno Haible <haible>
Mon 20 Jul 2020 08:03:21 PM UTC, comment #5: 

There's no 'gmake' on my OpenBSD 6.7 platform, so I assume you built and installed your own copy of GNU Make. One possibility is that you need to be consistent about which 'make' you're using, e.g., './configure MAKE=gmake'. Or you might try building with OpenBSD 'make', e.g., './configure && make && make check'.

By the way, I used the default PATH except with a directory containing GNU m4 1.4.18 at the start. I didn't add anything other than GNU m4.

> To me, it smells like 'gmake' has set some environment variables, and the test is invoking 'make', and 'make' interprets this environment variable in a strange way.

Yes, that sounds right. GNU Make sets MAKEFLAGS=w in the environment, and presumably this confuses OpenBSD Make.

Paul Eggert <eggert>
Group administrator
Sun 19 Jul 2020 07:03:42 AM UTC, comment #4: 


> OpenBSD 6.5 is no longer supported


I reproduce the problem with OpenBSD 6.7, both with an in-source build and a VPATH build. See the attached logs.

> everything worked for me.


I run

./configure && gmake && gmake check


The error message in the log file is

make: don't know how to make w


To me, it smells like 'gmake' has set some environment variables, and the test is invoking 'make', and 'make' interprets this environment variable in a strange way.

(file #49510, file #49511)

Bruno Haible <haible>
Sat 18 Jul 2020 06:35:00 PM UTC, comment #3: 

Odd, I just now tried a fresh OpenBSD 6.5 installation (amd64 guest on Ubuntu 18.04.3 host via VirtualBox) and everything worked for me. I downloaded, built and m4-1.4.18, and with that m4 in my PATH I downloaded, built and tested the same git checkout of Autoconf that you used, and all tests passed.

Wikipedia <https://en.wikipedia.org/wiki/OpenBSD_version_history> says OpenBSD 6.5 is no longer supported, so I expect we don't need to worry much about 6.5 any more.

So I tried OpenBSD 6.7, the current release, and got the same result: all tests behaved as expected (or were skipped).

Paul Eggert <eggert>
Group administrator
Sat 18 Jul 2020 12:58:02 PM UTC, comment #2: 

Well, no, Zacks patch did not fix these. I've created a tarball from the newest git checkout, and ran it on OpenBSD 6.5. The tests 221 and 222 still fail. Logs are attached.

(file #49504)

Bruno Haible <haible>
Fri 17 Jul 2020 11:42:28 PM UTC, comment #1: 

My guess is that the failures in 221 and 222 should be fixed by the patch Zack installed in:

https://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=7c08375081545e1eaf96461319ffec0a02e9f959

Paul Eggert <eggert>
Group administrator
Fri 17 Jul 2020 09:00:47 PM UTC, original submission:  

On OpenBSD 6.5, when running the test suite of autoconf-2.69 and -2.69b, two tests fail in 2.69b that did not exist in 2.69:

 221: autotest.at:1893   C unit tests
 222: autotest.at:1948   C unit tests (EXEEXT)


Find attached the test logs.

Bruno Haible <haible>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49510:  openbsd67-logs.tar.xz added by haible (158KiB - application/x-xz)
file #49511:  openbsd67-vpath-logs.tar.xz added by haible (159KiB - application/x-xz)
file #49504:  openbsd-logs.tar.xz added by haible (159KiB - application/x-xz)
file #49502:  openbsd-logs.tar.xz added by haible (192KiB - application/x-xz)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by eggert (Posted a comment)
  • -email is unavailable- added by haible (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-21 eggert StatusWorks For Me Done
        Open/ClosedOpen Closed
    2020-07-19 haible Attached File- Added openbsd67-logs.tar.xz, #49510
        Attached File- Added openbsd67-vpath-logs.tar.xz, #49511
    2020-07-18 eggert StatusNone Works For Me
    2020-07-18 haible Attached File- Added openbsd-logs.tar.xz, #49504
    2020-07-17 haible Attached File- Added openbsd-logs.tar.xz, #49502

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code