mainGNU ccRTP - Support: sr #105229, SingleRTPSessionPool is not thread...

 
 

sr #105229: SingleRTPSessionPool is not thread safe

Submitter:  Jörgen Terner <jorter>
Submitted:  Wed 15 Mar 2006 10:32:05 AM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  4 - Important Status:  Done
Privacy:  Public Assigned to:  None
Open/Closed:  Open Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 16 May 2006 03:31:00 PM UTC, comment #1: 


Hi, I've just commited this patch (and the one for
scheduling packets by timestamp in session pools) to CVS.
Les us know if you have additional comments or if there is
any issue.

Sorry for the delay and thanks a lot!

Federico Montesino Pouzols <fedemp>
Group Member
Wed 15 Mar 2006 10:32:05 AM UTC, original submission:  

I've tried to use the SingleRTPSessionPool. After several crashes I realized that it is not thread safe. Insertions and deletions are safe but the main loop is not! There is little point in protecting insertions and deletions if the code that reads the list is not protected.

The list of sessions is not the only problem. Add and remove modifies the variables used in the call to select, so after a call to select the recvSocketSet can be modified before it is used.

I've attached my modifications to the pool that seems to run ok.

Jörgen Terner <jorter>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #3883:  pool.h added by jorter (6KiB - text/plain - Modified thread safe session pool)
file #3882:  pool.cpp added by jorter (9KiB - text/plain - Modified thread safe session pool.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-05-16 fedemp StatusNone Done
    Carbon-Copy- Added -email is unavailable-
2006-03-15 jorter Attached File- Added pool.h, #217
2006-03-15 jorter Attached File- Added pool.cpp, #216

Back to the top

Copyright © 2024 Free Software Foundation, Inc.
Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
Page source code

Powered by Savane 3.13-54b4.
Corresponding source code