patchGNU Autoconf Archive - Patches: patch #8540, ax_boost_python: Several fixes

 
 

patch #8540: ax_boost_python: Several fixes

Submitted by:  Daniel Müllner <muellner>
Submitted on:  Sat 20 Sep 2014 08:10:01 PM UTC  
 
Priority:  5 - Normal Status:  Done
Assigned to:  Peter Simons <simons> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 16 Oct 2014 08:44:45 AM UTC, comment #4: 

OK. I pushed the update in commit db46196. Thanks!

Peter Simons <simons>
Project AdministratorIn charge of this item.
Wed 15 Oct 2014 06:43:12 PM UTC, comment #3: 

Since nobody answered my question about the variable names, let's stay on the safe side and use unique names instead of CPPFLAGS_SAVE etc., which are probably also used elsewhere.

I'm attaching the modified m4 file. Peter, could you please replace the original submission by this? Thanks very much!

(file #32279)

Daniel Müllner <muellner>
Wed 15 Oct 2014 08:52:56 AM UTC, comment #2: 

I pushed your update in b6962c1. Thank you very much for the patch!

Peter Simons <simons>
Project AdministratorIn charge of this item.
Sun 21 Sep 2014 12:22:01 PM UTC, comment #1: 

One question for the experts: Is it safe to write

    CPPFLAGS_SAVE="$CPPFLAGS"
    ...
    CPPFLAGS="$CPPFLAGS_SAVE"

or should I use a unique name like

    ax_boost_python_save_CPP_FLAGS

?

Daniel Müllner <muellner>
Sat 20 Sep 2014 08:10:01 PM UTC, original submission:  

I propose the attached file as a replacement for the current ax_boost_python. The new file addresses three issues:

(1) ax_boost_python must find out the correct library to link with. One tricky point here is that is must distinguish between "boost_python" for Python2 libraries and "boost_python3" libraries. The old macro used AC_CHECK_LIB, which failed to make the distinction if the linker flag "-Wl,--as-needed" is set (as is by default on Arch Linux). The new macro replaces AC_CHECK_LIB by a call to AC_LINK_IFELSE, which performs the job properly.

(2) The macro tests several possibilities for the library name. If the command line switch --with-boost-python=XXX is given, the old macro tried XXX last, which made it impossible to override auto-detect results. Now XXX is tried first, so that users can override the auto-detect results if they aren't correct for some reason.

(3) Following a tip by Paul Emsley, the macro now takes all relevant environment variables into account: PYTHON_CPPFLAGS, PYTHON_LDPFLAGS, BOOST_CPPFLAGS, and BOOST_LDFLAGS.

Daniel Müllner <muellner>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32279:  ax_boost_python.m4 added by muellner (5KiB - application/x-m4 - Similar to first submission, but unique variable names.)
file #32144:  ax_boost_python.m4 added by muellner (5KiB - application/x-m4)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by muellner (Submitted the item)
  •  

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-10-16 simons StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2014-10-15 muellner Attached File- => Added ax_boost_python.m4, #32279
    2014-10-15 simons StatusNone => Ready For Test
        Assigned toNone => simons
    2014-09-20 muellner Attached File- => Added ax_boost_python.m4, #32144

    Back to the top


    Powered by Savane 3.6