patchClasspath Extensions - Patches: patch #8296, gnu.inet.util.CRLFOutputStream add...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8296: gnu.inet.util.CRLFOutputStream add writeAtBOL notification methods

Submitter:  Conrad T. Pino <conradpino>
Submitted:  Wed 29 Jan 2014 01:20:52 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  In Progress Privacy:  Public
Assigned to:  conradpino Open/Closed:  Open

Wed 29 Jan 2014 11:26:15 AM UTC, comment #5: 

Upload patch file omitted from comment #4 update.


(file #30412)

Conrad T. Pino <conradpino>
Group Member
Wed 29 Jan 2014 11:08:05 AM UTC, comment #4: 

This patch update revises if statement layout and adds new constructor.

  protected CRLFOutputStream(CRLFOutputStream out)
  {
    super(out);
    atBOL = out.atBOL;
    last = out.last;
  }

The submitted patch file supersedes all prior versions.

Conrad T. Pino <conradpino>
Group Member
Wed 29 Jan 2014 10:45:47 AM UTC, comment #3: 

Excellent point; agreed.

Conrad T. Pino <conradpino>
Group Member
Wed 29 Jan 2014 10:42:01 AM UTC, comment #2: 

Please can you use curly braces to enclose all conditional statements, even if they are only 1 line.

Thus:
if (x) {
    do_y();
}

not:
if (x)
    do_y();

This improves code legibility and avoids a number of simple programmer errors that can occur.

Chris Burdess <dog>
Group administrator
Wed 29 Jan 2014 10:34:49 AM UTC, comment #1: 

Resolving https://savannah.gnu.org/bugs/?41383 issue requires an additional "public void ensureBOL() throws IOException" method.

Patch file #30403 is replaced by this submission.


(file #30409)

Conrad T. Pino <conradpino>
Group Member
Wed 29 Jan 2014 01:20:52 AM UTC, original submission:  

Add two (2) subclass notification methods to support resolving https://savannah.gnu.org/bugs/?40378#comment8 issue.

Conrad T. Pino <conradpino>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #30412:  CRLFOutputStream.patch added by conradpino (3KiB - application/octet-stream)
file #30409:  CRLFOutputStream.patch added by conradpino (3KiB - application/octet-stream)
file #30403:  CRLFOutputStream.patch added by conradpino (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dog (Posted a comment)
  • -email is unavailable- added by conradpino (Submitted the item)
  • -email is unavailable- added by conradpino
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-29 conradpino Attached File- Added CRLFOutputStream.patch, #30412
    2014-01-29 conradpino Attached File- Added CRLFOutputStream.patch, #30409
    2014-01-29 conradpino Attached File- Added CRLFOutputStream.patch, #30403
        Carbon-Copy- Added dog

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code