patchGNU Autoconf Archive - Patches: patch #9671, AX_COMPILER_VENDOR: Detecting...

 
 

patch #9671: AX_COMPILER_VENDOR: Detecting Fortran compilers, bug fixes

Submitter:  John Zaitseff <zaitseff>
Submitted:  Sun 05 Aug 2018 06:04:06 AM UTC
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

( Jump to the original submission )

Thu 14 Feb 2019 12:45:53 PM UTC, comment #11: 

Pushed to master. Thank you very much for re-submitting the patches!

Peter Simons <simons>
Project Administrator
Thu 14 Feb 2019 10:13:27 AM UTC, comment #10: 

One more slight bug fix: autoconf-archive-JNZ-5.diff, to fix the detection of the IBM compiler

(file #46262)

John Zaitseff <zaitseff>
Thu 14 Feb 2019 10:02:56 AM UTC, comment #9: 

"git rebase" makes regenerating the individual patches quite easy.  I've named them 1001-... to 1010-...

(file #46252, file #46253, file #46254, file #46255)

John Zaitseff <zaitseff>
Thu 14 Feb 2019 09:35:07 AM UTC, comment #8: 

A single patch is fine; you don't have to make an extra effort to break the changes into smaller patches. It's nicer for people who want to follow the changes to the macro, no doubt, but I realize it's a lot of effort.

Also, note that it's much easier for me to handle pull requests at https://github.com/autoconf-archive/autoconf-archive. If that is an option for you, then please feel free to submit your changes via github instead of attaching sets of patches to the issue tracker.

Peter Simons <simons>
Project Administrator
Thu 14 Feb 2019 09:29:52 AM UTC, comment #7: 

Question: is a single patch sufficient, or would you like me to break them up into a series as I did the first time?

John Zaitseff <zaitseff>
Thu 14 Feb 2019 09:02:57 AM UTC, comment #6: 

I tried to apply those patches today, but unfortunately there are conflicts with the current version of ax_compiler_vendor.m4 that I'm feeling somewhat uncomfortable resolving myself.

Things start breaking down with "ax_compiler_vendor.m4: Reformat the macro for readability".

Would it be possible to get a new set of patches that apply cleanly?

Peter Simons <simons>
Project Administrator
Mon 06 Aug 2018 05:08:07 AM UTC, comment #5: 

I have successfully tested this series of patches with the following compilers:

  • GCC 4.2.1, 4.4.7, 7.3.0, 8.2.0
  • Clang (LLVM) 5.0.1, 6.0.0
  • Portland PGI 18.3
  • Intel C 18.03
  • Sun (Solaris) Developer Studio 12.6
John Zaitseff <zaitseff>
Sun 05 Aug 2018 11:42:03 PM UTC, comment #4: 

Ninth patch to clarify why some compilers are listed early: they take too long to start up to be called dozens of times for compiler detection.

(file #44720)

John Zaitseff <zaitseff>
Sun 05 Aug 2018 11:20:30 PM UTC, comment #3: 

Patch #8 to make copyright lines consistent with other M4 files

(file #44718)

John Zaitseff <zaitseff>
Sun 05 Aug 2018 10:06:00 PM UTC, comment #2: 

A seventh patch to add detection of the NEC vector supercomputer SX compilers

(file #44717)

John Zaitseff <zaitseff>
Sun 05 Aug 2018 06:07:23 AM UTC, comment #1: 

If need be, I can combine the six patches into a single patch.  Please let me know.

I plan to change AX_CFLAGS_WARN_ALL and co to use AC_COMPILER_VENDOR for more robust detection of appropriate flags (AX_CFLAGS_WARN_ALL et al. currently get many compilers wrong...).

John Zaitseff <zaitseff>
Sun 05 Aug 2018 06:04:06 AM UTC, original submission:  

A total of six patches to make AX_COMPILER_VENDOR detect various Fortran compilers (previous version of this macro only did C and C++), plus bug-fixes for the Portland PGI C++ compiler.  Also added appropriate documentation and reformatted the macro for better readability.

John Zaitseff <zaitseff>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46260:  1009-ax_compiler_vendor.m4-Clarify-why-some-compilers-are.patch added by zaitseff (2KiB - text/x-patch - Second patch iteration, parts 9-10 of 10)
file #46261:  1010-ax_compiler_vendor.m4-Bump-version-number-and-copyri.patch added by zaitseff (1KiB - text/x-patch - Second patch iteration, parts 9-10 of 10)
file #46256:  1005-ax_compiler_vendor.m4-Reformat-the-macro-for-readabi.patch added by zaitseff (4KiB - text/x-patch - Second patch iteration, parts 5-8 of 10)
file #46257:  1006-ax_compiler_vendor.m4-Update-macro-documentation-to-.patch added by zaitseff (2KiB - text/x-patch - Second patch iteration, parts 5-8 of 10)
file #46258:  1007-ax_compiler_vendor.m4-Add-detection-of-the-NEC-SX-co.patch added by zaitseff (2KiB - text/x-patch - Second patch iteration, parts 5-8 of 10)
file #46259:  1008-ax_compiler_vendor.m4-Make-copyright-lines-consisten.patch added by zaitseff (1KiB - text/x-patch - Second patch iteration, parts 5-8 of 10)
file #46252:  1001-ax_compiler_vendor.m4-Bug-fix-remove-superfluous-spa.patch added by zaitseff (822B - text/x-patch - Second patch iteration, parts 1-4 of 10)
file #46253:  1002-ax_compiler_vendor.m4-Rearrange-the-Portland-PGI-com.patch added by zaitseff (1KiB - text/x-patch - Second patch iteration, parts 1-4 of 10)
file #46254:  1003-ax_compiler_vendor.m4-Enable-detection-of-the-Sun-Fo.patch added by zaitseff (927B - text/x-patch - Second patch iteration, parts 1-4 of 10)
file #46255:  1004-ax_compiler_vendor.m4-Make-preprocessor-directives-s.patch added by zaitseff (1020B - text/x-patch - Second patch iteration, parts 1-4 of 10)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by zaitseff (Submitted the item)
  •  

     

     

     

    Follow 25 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-14 simons StatusNeed Info Done
        Open/ClosedOpen Closed
    2019-02-14 simons Attached File#44711 Removed
    2019-02-14 simons Attached File#44717 Removed
    2019-02-14 simons Attached File#44708 Removed
    2019-02-14 simons Attached File#44709 Removed
    2019-02-14 simons Attached File#44706 Removed
    2019-02-14 simons Attached File#44707 Removed
    2019-02-14 simons Attached File#44710 Removed
    2019-02-14 simons Attached File#44718 Removed
    2019-02-14 simons Attached File#44720 Removed
    2019-02-14 zaitseff Attached File- Added autoconf-archive-JNZ-5.diff, #46262
    2019-02-14 zaitseff Attached File- Added 1009-ax_compiler_vendor.m4-Clarify-why-some-compilers-are.patch, #46260
        Attached File- Added 1010-ax_compiler_vendor.m4-Bump-version-number-and-copyri.patch, #46261
    2019-02-14 zaitseff Attached File- Added 1005-ax_compiler_vendor.m4-Reformat-the-macro-for-readabi.patch, #46256
        Attached File- Added 1006-ax_compiler_vendor.m4-Update-macro-documentation-to-.patch, #46257
        Attached File- Added 1007-ax_compiler_vendor.m4-Add-detection-of-the-NEC-SX-co.patch, #46258
        Attached File- Added 1008-ax_compiler_vendor.m4-Make-copyright-lines-consisten.patch, #46259
    2019-02-14 zaitseff Attached File- Added 1001-ax_compiler_vendor.m4-Bug-fix-remove-superfluous-spa.patch, #46252
        Attached File- Added 1002-ax_compiler_vendor.m4-Rearrange-the-Portland-PGI-com.patch, #46253
        Attached File- Added 1003-ax_compiler_vendor.m4-Enable-detection-of-the-Sun-Fo.patch, #46254
        Attached File- Added 1004-ax_compiler_vendor.m4-Make-preprocessor-directives-s.patch, #46255
    2019-02-14 simons StatusNone Need Info
        Assigned toNone simons
    2018-08-05 zaitseff Attached File- Added 0009-ax_compiler_vendor.m4-Clarify-why-some-compilers-are.patch, #44720

    Back to the top


    Powered by Savane 3.9