patchmake - Patches: patch #5142, prevent duplicate exports on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5142: prevent duplicate exports on Windows

Submitter:  James A <easy_money>
Submitted:  Tue 30 May 2006 02:13:22 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Fixed Release:  None

Mon 19 Jul 2010 12:11:50 AM UTC, comment #2: 

Can someone more familiar with Windows comment on whether a change like this is appropriate or not?  This particular implementation seems to me to be a bit problematic since for every new variable you loop through all variables already installed, which is very expensive indeed once you get too many.

But, if we could implement this more efficiently, would we even want to?

Paul D. Smith <psmith>
Group administrator
Tue 30 May 2006 04:47:01 PM UTC, comment #1: 

fixed xmalloc bug that did not manifest in debug builds

James A <easy_money>
Tue 30 May 2006 02:13:22 PM UTC, original submission:  

This patch attempts to prevent exports with different case from being defined in the environment.
By default the following Makefile will create two envs ENV1 and env1 for the childprocesses which is not
what most Windows users would expect.  The patch will only export the FIRST variable ENV1.

Combine with patch #2608 "Patch to uppercase environment variable names on input" for more Windows friendly usage

export ENV1 := Value
export env1 := value

all:
cmd /c "set"


Unpatched output
  ENV1=Value
  env1=value

Patched output
  ENV1=Value


James A <easy_money>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-05-30 easy_money Attached File- Added make-3.81-exportnodups.patch, #10082
    2006-05-30 easy_money Attached File- Added make-3.81-exportnodups.patch, #10080

    Back to the top

    Powered by Savane 3.13-12ab.
    Corresponding source code