patchGNU Autoconf Archive - Patches: patch #10284, ax_jni_include_dir: don't cache...


patch #10284: ax_jni_include_dir: don't cache result (it's broken)

Submitter:  Matt Whitlock <mwhitlock>
Submitted:  Sun 09 Oct 2022 05:49:56 AM UTC
Priority:  5 - Normal Status:  None
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup

Sun 09 Oct 2022 05:49:56 AM UTC, original submission:  

The AX_JNI_INCLUDE_DIR macro was violating the first rule of AC_CACHE_CHECK: "The commands-to-set-it must have no side effects except for setting the variable cache-id."[1] Specifically, JNI_INCLUDE_DIRS was being modified within the code block that was only supposed to be setting the value of ac_cv_jni_header_path. This was causing JNI_INCLUDE_DIRS to be incorrect/incomplete when ac_cv_jni_header_path was initialized from an Autoconf cache file.

Since the tests to find the JNI header paths are so trivial, there is nothing to be gained by caching the results. The most straightforward fix is not to cache, and that is the fix provided in this patch.


Matt Whitlock <mwhitlock>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by mwhitlock (Submitted the item)

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-10-09 mwhitlock Attached File- Added 0001-ax_jni_include_dir-don-t-cache-result.patch, #53818

    Back to the top

    Powered by Savane 3.12