patchGNU Autoconf Archive - Patches: patch #10284, ax_jni_include_dir: don't cache...

 
 

patch #10284: ax_jni_include_dir: don't cache result (it's broken)

Submitter:  Matt Whitlock <mwhitlock>
Submitted:  Sun 09 Oct 2022 05:49:56 AM UTC
   
 
Priority:  5 - Normal Status:  None
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Sun 09 Oct 2022 05:49:56 AM UTC, original submission:  

The AX_JNI_INCLUDE_DIR macro was violating the first rule of AC_CACHE_CHECK: "The commands-to-set-it must have no side effects except for setting the variable cache-id."[1] Specifically, JNI_INCLUDE_DIRS was being modified within the code block that was only supposed to be setting the value of ac_cv_jni_header_path. This was causing JNI_INCLUDE_DIRS to be incorrect/incomplete when ac_cv_jni_header_path was initialized from an Autoconf cache file.

Since the tests to find the JNI header paths are so trivial, there is nothing to be gained by caching the results. The most straightforward fix is not to cache, and that is the fix provided in this patch.

[1] https://www.gnu.o ... hing-Results.html

Matt Whitlock <mwhitlock>

 

Attached Files

Attached Files

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by mwhitlock (Submitted the item)
  •  

    History

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-10-09 mwhitlock Attached File- Added 0001-ax_jni_include_dir-don-t-cache-result.patch, #53818

    Back to the top

    Powered by Savane 3.16-11ef.
    Corresponding source code