patchGNU Autoconf Archive - Patches: patch #10065, fix shell syntax in...

 
 

patch #10065: fix shell syntax in AX_JNI_INCLUDE_DIR

Submitted by:  None
Submitted on:  Wed 12 May 2021 04:39:36 PM UTC  
 
Priority:  5 - Normal Status:  None
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 12 May 2021 05:20:20 PM UTC, comment #1: 

On investigating further, the single brackets are actually ok. It's just that $macos_version is an empty string because the parsing magic before that didn't work (sw_vers is 11.3 here, but the sed command looks for some x.y.z; further, it would then set macos_version=y, which was ok when the macOS version was 10.y.z).

Still might make sense to apply the patch and switch to use `test`.

Anonymous
Wed 12 May 2021 04:39:36 PM UTC, original submission:  

In ax_jni_include_dir.m4:77, the line

            if @<:@ "$macos_version" -gt "7" @:>@; then

ends up as

            if [ "$macos_version" -gt "7" ]; then

in configure.
This does not execute nicely:

../configure: line 26105: [: : integer expression expected

Probably [[ ... ]] was meant, but it would be even nicer to use the portable explicit call of test here, too.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51427:  ax_jni_include_dir.m4.patch added by None (628B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-12 None Attached File- => Added ax_jni_include_dir.m4.patch, #51427

    Back to the top


    Powered by Savane 3.7