GNU nano - Bugs: bug #53387, reading a file into a new buffer...
You are not allowed to post comments on this tracker with your current authentication level.
bug #53387: reading a file into a new buffer should not be undoable
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Mon 19 Mar 2018 08:21:54 PM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Tue 20 Mar 2018 10:24:08 AM UTC, comment #3: |
Benno Schulenberg <bens> |
Mon 19 Mar 2018 08:57:52 PM UTC, comment #2: If we assume that undo operations apply only to the current buffer, your idea makes perfect sense.
|
David Lawrence Ramsey <dolorous> |
Mon 19 Mar 2018 08:34:11 PM UTC, comment #1: David, can you have a look at this? To see whether you agree with what I describe as the expected behavior. And whether the patch does not have any undesired side effects. |
Benno Schulenberg <bens> |
Mon 19 Mar 2018 08:21:54 PM UTC, original submission:
To reproduce, run:
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-03-30 | bens | Open/Closed | Open | Closed | |
2018-03-20 | bens | Status | In Progress | Fixed | |
2018-03-19 | bens | Attached File | - | Added dont-allow-undoing-a-new-buffer.patch, #43596 | |
Carbon-Copy | - | Added dolorous | |||
2018-03-19 | bens | Summary | undoing the opening of a second file does not mark it as Modified | reading a file into a new buffer should not be undoable |
Powered by Savane 3.13-3230.
Corresponding source code
Thanks for testing. I've applied a more conservative patch: commit a1132c81.
(I think that 'undoable' and 'new_buffer' should always be the inverse of each other, but I'm not entirely sure. That thought made me run into this problem in the first place.)