bugmake - Bugs: bug #1418, make -t core dumps


bug #1418: make -t core dumps

Submitted by:  None
Submitted on:  Mon 14 Oct 2002 11:43:08 PM UTC
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  3.80 Operating System:  POSIX-Based
Fixed Release:  3.81 Triage Status:  None
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:
       No canned response available


Tue 15 Oct 2002 01:53:53 AM UTC, comment #1: 

According to POSIX a target with no commands should not be touched with -t.  I implemented a patch for this which fixes the bug.

Paul D. Smith <psmith>
Project Administrator
Mon 14 Oct 2002 11:43:08 PM UTC, original submission:  

Given a makefile that starts as the following
HERE:=$(dir $(word $(words  ${MAKEFILE_LIST}),${MAKEFILE_LIST}))

T:=Z$(subst /,_,${HERE})


ALL+= $T

for Make-3.80rc2, then make -t dumps core. Yes, I know I can not spell '.PHONY', but that is no excuse. The problem occurs in the function 'notice_finished_file', line 790, where it says

          for (i = file->cmds->ncommand_lines; i > 0; --i)

just after it has done the 'touch' on the file Zcurrent_dir_with_slash_changed_to_underscore_

At this point, file->cmds is a NULL pointer, so it can not be dereferenced. If I could spell, the line would not be reached, but file->phony is 0 with my spelling mistake.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #109:  remake.c-diff added by psmith (626B - application/octet-stream - Patch to remake.c)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.





Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-04-01 psmith Fixed Release4.0 => 3.81
2002-10-15 psmith Fixed ReleaseNone => (Error - Not Found)
2002-10-15 psmith StatusNone => (Error - Not Found)
    Assigned toNone => NA
    Open/ClosedOpen => (Error - Not Found)

Back to the top

Powered by Savane 3.9