bugGnash - The GNU Flash player - Bugs: bug #32833, SWF6: BitmapFill referencing...

 
 

bug #32833: SWF6: BitmapFill referencing missing bitmap is rendered wrong

Submitter:  Sandro Santilli <strk>
Submitted:  Fri 18 Mar 2011 02:59:18 PM UTC
   
 
Category:  renderer Severity:  3 - Normal
Release:  master Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 18 Mar 2011 06:36:55 PM UTC, comment #6: 

So, cf2c372 fixes it by moving the disposed() checking in renderer.

Sandro Santilli <strk>
Group Member
Fri 18 Mar 2011 05:51:22 PM UTC, comment #5: 

Having BitmapFill::bitmap() return disposed CachedBitmaps rather than handing a 0 out in that case would let the renderer choose what to do based on that.

Sandro Santilli <strk>
Group Member
Fri 18 Mar 2011 05:01:24 PM UTC, comment #4: 

in the BeginBitmapFill.swf case, the lower-right rectangle is filled using drawing API and a bitmap which is disposed right after the drawing command.

The adobe player shows the resulting drawing to be transparent.
Not disposing the thing would show it green.
Gnash is now showing it red (as it becomes a missing bitmap in a BitmapFillStyle).

Dunno yet how we could distinguish between the two cases.
I've tested the missing_bitmap.xml in version 8, but doesn't make a difference.

Sandro Santilli <strk>
Group Member
Fri 18 Mar 2011 04:54:40 PM UTC, comment #3: 

Unfortunatly, the commit broke BeginBitmapFill.swf in misc-ming.all.

Luckly, somebody bothered making that test (wonderful!)

Sandro Santilli <strk>
Group Member
Fri 18 Mar 2011 04:27:59 PM UTC, comment #2: 

Fixed for AGG with 2fd706f
Haven't checked cairo

Sandro Santilli <strk>
Group Member
Fri 18 Mar 2011 03:57:29 PM UTC, comment #1: 

automated test is in place as of 4b75a4faa7aa7c8b9a83338bbef6c1ee05925b90
expects the failure.

The test should be improved to add another shape referencing another missing bitmap but with different id. I wasn't that good at it.

Sandro Santilli <strk>
Group Member
Fri 18 Mar 2011 02:59:18 PM UTC, original submission:  

It turns out the infamous 65535 BitmapFill case should give a red solid fill, gnash does not get this right.

In general, it seems that any missing bitmap referenced by a bitmapfill should yeld that red.

I'm working on a testcase

Sandro Santilli <strk>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-03-18 strk StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2011-03-18 strk StatusIn Progress Ready For Test
    2011-03-18 strk StatusReady For Test In Progress
    2011-03-18 strk StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code